Add UseCounter for non-standard getComputedStyle(e).cssX behaviour

Add UseCounter for non-standard getComputedStyle(e).cssX behaviour

Blink and WebKit supports non-standard behaviour e.g.
getComputedStyle(e).cssBoxShadow. We suspect that a very few websites
(or none at all) use this. This CL adds a UseCounter for this
non-standard behaviour.

BUG=413205
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183230

[Sunil Ratnu, 2014-10-03 13:42:41]

Patchset #1 (id:1) has been deleted

[Sunil Ratnu, 2014-10-03 13:43:58]

sunil.ratnu@samsung.com changed reviewers:
+ haraken@chromium.org, timloh@chromium.org

[Sunil Ratnu, 2014-10-03 13:43:58]

Please have a look.

Thanks!
Sunil

[haraken, 2014-10-03 14:07:27]

https://codereview.chromium.org/621283002/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp (right):

https://codereview.chromium.org/621283002/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp:103: return
CSSPropertyInvalid;

Are you planning to actually change the behavior before getting enough user
counter numbers?

We normally change the behavior after confirming that the use counter numbers
are small enough.

[Sunil Ratnu, 2014-10-03 14:22:32]

https://codereview.chromium.org/621283002/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp (right):

https://codereview.chromium.org/621283002/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp:103: return
CSSPropertyInvalid;
On 2014/10/03 14:07:27, haraken wrote:
> 
> Are you planning to actually change the behavior before getting enough user
> counter numbers?
> 
> We normally change the behavior after confirming that the use counter numbers
> are small enough.

Yeah correct, that is the usual flow. I might have misread the bug (usecounter
and remove). The bug description must have meant "UseCounter and then eventually
remove".
I think we should stay with using Counters first and then removing the
behaviour. If you say so, I will upload a new patch with just using counters.
Your final take?

[haraken, 2014-10-03 14:28:26]

On 2014/10/03 14:22:32, Sunil Ratnu wrote:
>
https://codereview.chromium.org/621283002/diff/20001/Source/bindings/core/v8/...
> File Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp (right):
> 
>
https://codereview.chromium.org/621283002/diff/20001/Source/bindings/core/v8/...
> Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp:103: return
> CSSPropertyInvalid;
> On 2014/10/03 14:07:27, haraken wrote:
> > 
> > Are you planning to actually change the behavior before getting enough user
> > counter numbers?
> > 
> > We normally change the behavior after confirming that the use counter
numbers
> > are small enough.
> 
> Yeah correct, that is the usual flow. I might have misread the bug (usecounter
> and remove). The bug description must have meant "UseCounter and then
eventually
> remove".
> I think we should stay with using Counters first and then removing the
> behaviour. If you say so, I will upload a new patch with just using counters.
> Your final take?

Yes, that should be a right way to go.

[Sunil Ratnu, 2014-10-04 09:31:25]

Hi haraken,

Thanks for the review. I am now only adding use counter and not changing the
behaviour. Please have a look at the latest patch.

Thanks!
Sunil

[haraken, 2014-10-04 11:57:16]

LGTM

[Sunil Ratnu, 2014-10-04 12:02:46]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-10-04 12:03:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/621283002/40001

[commit-bot: I haz the power, 2014-10-04 13:37:52]

Committed patchset #2 (id:40001) as 183230