linux: pass a bunch more ui tests.

linux: pass a bunch more ui tests.

Mostly random portability fixes: use portable functions, use FilePath, etc.

[Evan Martin, 2009-04-07 21:25:13]

+pawel, since he's been working in this space (I eagerly await that process
watcher commit...)

[Evan Stade, 2009-04-07 22:14:37]

sweet

http://codereview.chromium.org/62117/diff/20/25
File chrome/common/json_value_serializer.h (left):

http://codereview.chromium.org/62117/diff/20/25#oldcode98
Line 98: #endif  // CHROME_COMMON_JSON_VALUE_SERIALIZER_H__
single trailing underscore while you're here

http://codereview.chromium.org/62117/diff/20/26
File chrome/common/pref_service_uitest.cc (right):

http://codereview.chromium.org/62117/diff/20/26#newcode44
Line 44: // Make the copy writable
does file_util::CopyFile really do different things on linux and windows (as far
as permissions)? That seems bad.

http://codereview.chromium.org/62117/diff/20/26#newcode80
Line 80: // (minus the Windows bits) compiles fine on my Linux box now.
if you can make it compile, perhaps it would be a good idea to do so, and just
disable it on linux (by #ifdefing the test name). Up to you though.

[Evan Martin, 2009-04-07 22:36:05]

now passing more tests

http://codereview.chromium.org/62117/diff/20/26
File chrome/common/pref_service_uitest.cc (right):

http://codereview.chromium.org/62117/diff/20/26#newcode44
Line 44: // Make the copy writable
On 2009/04/07 22:14:37, estade wrote:
> does file_util::CopyFile really do different things on linux and windows (as
far
> as permissions)? That seems bad.

I talked with officemates about it and updated the comments.  We should just
assume it's impossible to create a non-writable file on Linux, since while it is
possible it is insane.

http://codereview.chromium.org/62117/diff/20/26#newcode80
Line 80: // (minus the Windows bits) compiles fine on my Linux box now.
On 2009/04/07 22:14:37, estade wrote:
> if you can make it compile, perhaps it would be a good idea to do so, and just
> disable it on linux (by #ifdefing the test name). Up to you though.

A lot of the body of the test is currently Windows-specific, so I'd rather just
leave it out for now.

[Evan Stade, 2009-04-07 23:10:55]

good lookin to me