Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Side by Side Diff: PRESUBMIT.py

Issue 621153003: Move mojo edk into mojo/edk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix checkdeps Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 'New code should not use ScopedAllowIO. Post a task to the blocking', 165 'New code should not use ScopedAllowIO. Post a task to the blocking',
166 'pool or the FILE thread instead.', 166 'pool or the FILE thread instead.',
167 ), 167 ),
168 True, 168 True,
169 ( 169 (
170 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", 170 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$",
171 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_loader\.cc$", 171 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_loader\.cc$",
172 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$", 172 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$",
173 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", 173 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
174 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", 174 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
175 r"^mojo[\\\/]system[\\\/]raw_shared_buffer_posix\.cc$", 175 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" +
176 r"simple_platform_shared_buffer_posix\.cc$",
176 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", 177 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$",
177 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$", 178 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$",
178 ), 179 ),
179 ), 180 ),
180 ( 181 (
181 'SkRefPtr', 182 'SkRefPtr',
182 ( 183 (
183 'The use of SkRefPtr is prohibited. ', 184 'The use of SkRefPtr is prohibited. ',
184 'Please use skia::RefPtr instead.' 185 'Please use skia::RefPtr instead.'
185 ), 186 ),
(...skipping 1512 matching lines...) Expand 10 before | Expand all | Expand 10 after
1698 builders.extend(['cros_x86']) 1699 builders.extend(['cros_x86'])
1699 1700
1700 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1701 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1701 # unless they're .gyp(i) files as changes to those files can break the gyp 1702 # unless they're .gyp(i) files as changes to those files can break the gyp
1702 # step on that bot. 1703 # step on that bot.
1703 if (not all(re.search('^chrome', f) for f in files) or 1704 if (not all(re.search('^chrome', f) for f in files) or
1704 any(re.search('\.gypi?$', f) for f in files)): 1705 any(re.search('\.gypi?$', f) for f in files)):
1705 builders.extend(['android_aosp']) 1706 builders.extend(['android_aosp'])
1706 1707
1707 return GetDefaultTryConfigs(builders) 1708 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698