Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 621093002: Clear the FIFO when calling input stream::Stop() (Closed)

Created:
6 years, 2 months ago by no longer working on chromium
Modified:
6 years, 2 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clear the FIFO when calling input stream::Stop() BUG= TEST=bots. Committed: https://crrev.com/046de0e4e7c3aba3e5fd922549c6b42a72eb02a5 Cr-Commit-Position: refs/heads/master@{#297904}

Patch Set 1 #

Patch Set 2 : removed alsa #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M media/audio/mac/audio_low_latency_input_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/pulse/pulse_input.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
no longer working on chromium
Dale, could you please review this small CL, I have already verified that there is ...
6 years, 2 months ago (2014-10-02 19:58:33 UTC) #2
DaleCurtis
lgtm
6 years, 2 months ago (2014-10-02 20:00:26 UTC) #3
no longer working on chromium
On 2014/10/02 20:00:26, DaleCurtis wrote: > lgtm Thanks.
6 years, 2 months ago (2014-10-02 20:01:33 UTC) #5
no longer working on chromium
On 2014/10/02 20:00:26, DaleCurtis wrote: > lgtm Thanks.
6 years, 2 months ago (2014-10-02 20:01:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621093002/20001
6 years, 2 months ago (2014-10-02 20:04:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 42c167baeb932c4c0302356b79f1b6fa728e4d38
6 years, 2 months ago (2014-10-02 21:18:23 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 21:18:56 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/046de0e4e7c3aba3e5fd922549c6b42a72eb02a5
Cr-Commit-Position: refs/heads/master@{#297904}

Powered by Google App Engine
This is Rietveld 408576698