Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 62103015: Revert 234975 "Work in progress for end-to-end bindings" (Closed)

Created:
7 years, 1 month ago by mmenke
Modified:
7 years, 1 month ago
Reviewers:
DaveMoore
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 234975 "Work in progress for end-to-end bindings" This apparently broke the win and mac debug trybots. > Work in progress for end-to-end bindings > > R=darin@chromium.org > > Review URL: https://codereview.chromium.org/72123002 TBR=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -212 lines) Patch
D trunk/src/mojo/examples/hello_world_service/hello_world_service.mojom View 1 chunk +0 lines, -17 lines 0 comments Download
D trunk/src/mojo/examples/hello_world_service/hello_world_service_impl.h View 1 chunk +0 lines, -27 lines 0 comments Download
D trunk/src/mojo/examples/hello_world_service/hello_world_service_impl.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D trunk/src/mojo/examples/sample_app/hello_world_client_impl.h View 1 chunk +0 lines, -32 lines 0 comments Download
D trunk/src/mojo/examples/sample_app/hello_world_client_impl.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M trunk/src/mojo/examples/sample_app/sample_app.cc View 2 chunks +46 lines, -32 lines 0 comments Download
M trunk/src/mojo/mojo.gyp View 2 chunks +0 lines, -36 lines 0 comments Download
M trunk/src/mojo/public/bindings/mojom_bindings_generator.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/mojo/shell/app_container.h View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/mojo/shell/app_container.cc View 2 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mmenke
7 years, 1 month ago (2013-11-14 03:35:44 UTC) #1
mmenke
7 years, 1 month ago (2013-11-14 03:36:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r235034.

Powered by Google App Engine
This is Rietveld 408576698