Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 62103008: Add a script for running pdfviewer and comparing to existing results. (Closed)

Created:
7 years, 1 month ago by scroggo
Modified:
7 years, 1 month ago
Reviewers:
edisonn, epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add a script for running pdfviewer and comparing to existing results. For quick, local checking to see how changes to pdfviewer have changed PDF files. Scripts were originally written by edisonn, and updated here for checkin. R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=12241

Patch Set 1 #

Patch Set 2 : 100 chars. #

Total comments: 2

Patch Set 3 : Respond to comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
experimental/PdfViewer/scripts/test_all_pdfs.sh View 1 2 1 chunk +92 lines, -0 lines 1 comment Download
experimental/PdfViewer/scripts/vm_pdf_viewer_run_one_pdf.sh View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scroggo
7 years, 1 month ago (2013-11-08 19:30:51 UTC) #1
epoger
lgtm https://codereview.chromium.org/62103008/diff/30001/experimental/PdfViewer/scripts/test_all_pdfs.sh File experimental/PdfViewer/scripts/test_all_pdfs.sh (right): https://codereview.chromium.org/62103008/diff/30001/experimental/PdfViewer/scripts/test_all_pdfs.sh#newcode12 experimental/PdfViewer/scripts/test_all_pdfs.sh:12: Many threads will be run simultaneously using the ...
7 years, 1 month ago (2013-11-11 18:56:17 UTC) #2
scroggo
https://codereview.chromium.org/62103008/diff/30001/experimental/PdfViewer/scripts/test_all_pdfs.sh File experimental/PdfViewer/scripts/test_all_pdfs.sh (right): https://codereview.chromium.org/62103008/diff/30001/experimental/PdfViewer/scripts/test_all_pdfs.sh#newcode12 experimental/PdfViewer/scripts/test_all_pdfs.sh:12: Many threads will be run simultaneously using the tool ...
7 years, 1 month ago (2013-11-12 14:51:44 UTC) #3
scroggo
7 years, 1 month ago (2013-11-12 14:52:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r12241 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698