Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: Source/modules/serviceworkers/RespondWithObserver.h

Issue 621003002: [ServiceWorker] Treat opaque response as a network error for frame loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/RespondWithObserver.h
diff --git a/Source/modules/serviceworkers/RespondWithObserver.h b/Source/modules/serviceworkers/RespondWithObserver.h
index ec26c3c3fc3fb0a1452c4f271ca8316aca69effe..b0a8d531d6ed375e3186b25822a5fa693fc4ddd8 100644
--- a/Source/modules/serviceworkers/RespondWithObserver.h
+++ b/Source/modules/serviceworkers/RespondWithObserver.h
@@ -23,7 +23,7 @@ class ScriptValue;
// notifies the client.
class RespondWithObserver FINAL : public GarbageCollectedFinalized<RespondWithObserver>, public ContextLifecycleObserver {
public:
- static RespondWithObserver* create(ExecutionContext*, int eventID, WebURLRequest::FetchRequestMode);
+ static RespondWithObserver* create(ExecutionContext*, int eventID, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType);
virtual void contextDestroyed() OVERRIDE;
@@ -41,10 +41,11 @@ public:
private:
class ThenFunction;
- RespondWithObserver(ExecutionContext*, int eventID, WebURLRequest::FetchRequestMode);
+ RespondWithObserver(ExecutionContext*, int eventID, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType);
int m_eventID;
WebURLRequest::FetchRequestMode m_requestMode;
+ WebURLRequest::FrameType m_frameType;
enum State { Initial, Pending, Done };
State m_state;

Powered by Google App Engine
This is Rietveld 408576698