Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/android/java/res/drawable/website_settings_permission_spinner_item_background.xml

Issue 620983002: Add Permissions to the PageInfo dialog on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_info_dialog_shell_only_v2
Patch Set: Added TODO to rename class to PageInfo Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/drawable/website_settings_permission_spinner_item_background.xml
diff --git a/chrome/android/java/res/drawable/website_settings_permission_spinner_item_background.xml b/chrome/android/java/res/drawable/website_settings_permission_spinner_item_background.xml
new file mode 100644
index 0000000000000000000000000000000000000000..141ebf561e1ddd59292010fe181e1e222c4817a5
--- /dev/null
+++ b/chrome/android/java/res/drawable/website_settings_permission_spinner_item_background.xml
@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<!-- Copyright 2014 The Chromium Authors. All rights reserved.
+
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file.
+-->
+<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
Ted C 2014/10/09 01:25:14 The spinner underline isn't consistent with the ne
sashab 2014/10/14 02:53:16 I'm trying to match the mocks, and I'm developing
+ <!-- To achieve a single border along the bottom, draw a rectangle offset by
+ 1dp in all dimensions but the bottom. -->
+ <item android:top="-1dp" android:right="-1dp" android:left="-1dp">
+ <shape android:shape="rectangle" >
+ <solid android:color="@android:color/transparent" />
Ted C 2014/10/09 01:25:14 why is this necessary?
sashab 2014/10/14 02:53:16 Sorry; didn't realise transparent was the default.
+ <stroke android:width="1dip" android:color="@color/website_settings_popup_permission_spinner_border"/>
+ </shape>
+ </item>
+
+</layer-list>

Powered by Google App Engine
This is Rietveld 408576698