Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2488)

Unified Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 620983002: Add Permissions to the PageInfo dialog on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_info_dialog_shell_only_v2
Patch Set: Made copy button close dialog, moved connection message into java, fixed way internal pages are det… Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/website_settings.cc
diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc
index eeff75194caad569d6a502838e94c5f34081dfa0..b95afb7798c424f13dd3d6cb49d4f963c9080fda 100644
--- a/chrome/browser/ui/website_settings/website_settings.cc
+++ b/chrome/browser/ui/website_settings/website_settings.cc
@@ -337,7 +337,8 @@ void WebsiteSettings::OnRevokeSSLErrorBypassButtonPressed() {
void WebsiteSettings::Init(Profile* profile,
const GURL& url,
const content::SSLStatus& ssl) {
- if (url.SchemeIs(content::kChromeUIScheme)) {
+ if (url.SchemeIs(content::kChromeUIScheme) ||
+ url.SchemeIs(url::kAboutScheme)) {
site_identity_status_ = SITE_IDENTITY_STATUS_INTERNAL_PAGE;
site_identity_details_ =
l10n_util::GetStringUTF16(IDS_PAGE_INFO_INTERNAL_PAGE);
@@ -345,6 +346,16 @@ void WebsiteSettings::Init(Profile* profile,
return;
}
+#if defined(OS_ANDROID)
+ if (url.SchemeIs(chrome::kChromeUINativeScheme)) {
Ted C 2014/10/16 21:30:45 I think it should be ok to ugly if def this in the
sashab 2014/10/17 00:51:27 Thought of a cool way to do this :) Done.
+ site_identity_status_ = SITE_IDENTITY_STATUS_INTERNAL_PAGE;
+ site_identity_details_ =
+ l10n_util::GetStringUTF16(IDS_PAGE_INFO_INTERNAL_PAGE);
+ site_connection_status_ = SITE_CONNECTION_STATUS_INTERNAL_PAGE;
+ return;
+ }
+#endif
+
scoped_refptr<net::X509Certificate> cert;
// Identity section.

Powered by Google App Engine
This is Rietveld 408576698