chrome/android/java/res/values/dimens.xml - Issue 620983002: Add Permissions to the PageInfo dialog on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 620983002: Add Permissions to the PageInfo dialog on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_info_dialog_shell_only_v2

Patch Set: Made copy button close dialog, moved connection message into java, fixed way internal pages are det… Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values/colors.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/values/dimens.xml

diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml

index 38def67ebc5d2a666b8e1efc5cdb41d4d385aa6b..9b5e03039296bbd5a969daf94be2c35a77d042d8 100644

--- a/chrome/android/java/res/values/dimens.xml

+++ b/chrome/android/java/res/values/dimens.xml

@@ -10,12 +10,13 @@

- <dimen name="website_settings_margin_top">16dp</dimen>

- <dimen name="website_settings_margin_sides">16dp</dimen>

- <dimen name="website_settings_margin_bottom">18dp</dimen>

- <dimen name="website_settings_margin_below_url">10dp</dimen>

- <dimen name="website_settings_url_title_size">16dp</dimen>

- <dimen name="website_settings_url_description_size">12dp</dimen>

+ <dimen name="website_settings_popup_padding_sides">16dp</dimen>

+ <dimen name="website_settings_popup_button_text_size">14dp</dimen>

+ <dimen name="website_settings_popup_button_height">36dp</dimen>

+ <dimen name="website_settings_popup_button_padding_sides">8dp</dimen>

+ <dimen name="website_settings_popup_button_margin_sides">4dp</dimen>

+ <dimen name="website_settings_popup_permission_icon_size">24dp</dimen>

+ <dimen name="website_settings_popup_permission_spinner_text_size">16dp</dimen>