chrome/android/java/res/drawable/website_settings_permission_spinner_dropdown_item.xml - Issue 620983002: Add Permissions to the PageInfo dialog on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/drawable/website_settings_permission_spinner_dropdown_item.xml

Issue 620983002: Add Permissions to the PageInfo dialog on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_info_dialog_shell_only_v2

Patch Set: Review feedback, UI feedback and moved Permission Settings strings into Android Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/page_info_popups.png ('k') | chrome/android/java/res/drawable/website_settings_permission_spinner_item.xml » ('j') | chrome/android/java/res/layout/website_settings.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/drawable/website_settings_permission_spinner_dropdown_item.xml

diff --git a/chrome/android/java/res/layout/distilled_page_font_family_spinner.xml b/chrome/android/java/res/drawable/website_settings_permission_spinner_dropdown_item.xml

similarity index 53%

copy from chrome/android/java/res/layout/distilled_page_font_family_spinner.xml

copy to chrome/android/java/res/drawable/website_settings_permission_spinner_dropdown_item.xml

index 431fad7f51bba7cd67994a7831ddf539864bd4b2..5b898f53b0cd00340982ac80c6196f45c65779b2 100644

--- a/chrome/android/java/res/layout/distilled_page_font_family_spinner.xml

+++ b/chrome/android/java/res/drawable/website_settings_permission_spinner_dropdown_item.xml

@@ -1,17 +1,16 @@

<?xml version="1.0" encoding="utf-8"?>

Use of this source code is governed by a BSD-style license that can be

found in the LICENSE file.

-->

<TextView xmlns:android="http://schemas.android.com/apk/res/android"

+ android:id="@android:id/text1"

style="?android:attr/spinnerDropDownItemStyle"

+ android:singleLine="true"

android:layout_width="match_parent"

- android:layout_height="wrap_content"

- android:layout_marginTop="10dp"

- android:layout_marginBottom="10dp"

- android:padding="10dp"

- android:ellipsize="end"

- android:singleLine="true" />

+ android:layout_height="?android:attr/listPreferredItemHeight"

+ android:textColor="@color/website_settings_popup_permission_spinner_text"

+ android:textSize="@dimen/website_settings_popup_permission_spinner_text_size"

+ android:ellipsize="marquee" />