chrome/android/java/res/layout/website_settings_permission_row.xml - Issue 620983002: Add Permissions to the PageInfo dialog on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/website_settings_permission_row.xml

Issue 620983002: Add Permissions to the PageInfo dialog on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_info_dialog_shell_only_v2

Patch Set: Added TODO to rename class to PageInfo Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/website_settings.xml ('K') | « chrome/android/java/res/layout/website_settings.xml ('k') | chrome/android/java/res/values/colors.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright (c) 2013 The Chromium Authors. All rights reserved.
	Ted C 2014/10/09 01:25:14 no (c) and 2014 no (c) and 2014 sashab 2014/10/14 02:53:17 Done. Show quoted text On 2014/10/09 01:25:14, Ted C wrote: > no (c) and 2014 Done.
	4

	5 Use of this source code is governed by a BSD-style license that can be

	6 found in the LICENSE file.

	7 -->

	8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:orientation="horizontal"

	12 android:paddingTop="@dimen/website_settings_popup_permission_padding_top" >

	13

	14 <ImageView

	15 android:id="@+id/website_settings_permission_icon"

	16 android:layout_width="@dimen/website_settings_popup_permission_icon_size "

	17 android:layout_height="@dimen/website_settings_popup_permission_icon_siz e" />

	18

	19 <LinearLayout

	20 android:layout_width="match_parent"

	21 android:layout_height="wrap_content"

	22 android:orientation="vertical"

	23 android:paddingStart="@dimen/website_settings_popup_permission_margin_be tween_icon_and_name" >

	24

	25 <TextView

	26 android:id="@+id/website_settings_permission_name"

	27 android:layout_width="match_parent"

	28 android:layout_height="wrap_content"

	29 android:text="Automatic downloads"
	Ted C 2014/10/09 01:25:14 remove this remove this sashab 2014/10/14 02:53:17 Done. Show quoted text On 2014/10/09 01:25:14, Ted C wrote: > remove this Done.
	30 android:textColor="@color/website_settings_popup_permission_name"

	31 android:textSize="@dimen/website_settings_popup_permission_name"
	Ted C 2014/10/09 01:25:14 for text sizes, the dimens should include text_siz for text sizes, the dimens should include text_size sashab 2014/10/14 02:53:17 Removed this one anyway. And all the other textSiz Show quoted text On 2014/10/09 01:25:14, Ted C wrote: > for text sizes, the dimens should include text_size Removed this one anyway. And all the other textSize dimens attributes say _size at the end.
	32 android:textStyle="bold" />

	33

	34 <Spinner

	35 android:id="@+id/website_settings_permission_spinner"

	36 android:layout_width="match_parent"

	37 android:layout_height="wrap_content" />

	38 </LinearLayout>

	39

	40 </LinearLayout>

OLD	NEW