chrome/android/java/res/drawable/website_settings_permission_spinner_item.xml - Issue 620983002: Add Permissions to the PageInfo dialog on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable/website_settings_permission_spinner_item.xml

Issue 620983002: Add Permissions to the PageInfo dialog on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_info_dialog_shell_only_v2

Patch Set: Added TODO to rename class to PageInfo Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/drawable/website_settings_permission_spinner_dropdown_item.xml ('K') | « chrome/android/java/res/drawable/website_settings_permission_spinner_dropdown_item.xml ('k') | chrome/android/java/res/drawable/website_settings_permission_spinner_item_background.xml » ('j') | chrome/android/java/res/drawable/website_settings_permission_spinner_item_background.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2

	3 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

	4

	5 Use of this source code is governed by a BSD-style license that can be

	6 found in the LICENSE file.

	7 -->

	8 <TextView xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:id="@android:id/text1"

	10 style="?android:attr/spinnerItemStyle"

	11 android:layout_width="match_parent"

	12 android:layout_height="@dimen/website_settings_popup_permission_spinner"
	Ted C 2014/10/09 01:25:13 in general, we typically don't define dimens (and in general, we typically don't define dimens (and often colors) if they are only used in a single place. This applies to the rest of the CL. Granted, if you are sharing top/left/bottom of padding of one view, you would also put right there if it was only used once just for consistency. Always defining externally ends up causing a lot of hopping around when reading/updating. Granted, if all the dimens you are adding are used all over then disregard this. sashab 2014/10/14 02:53:16 Fixed this everywhere; there were a lot of places Show quoted text On 2014/10/09 01:25:13, Ted C wrote: > in general, we typically don't define dimens (and often colors) if they are only > used in a single place. This applies to the rest of the CL. Granted, if you > are sharing top/left/bottom of padding of one view, you would also put right > there if it was only used once just for consistency. Always defining externally > ends up causing a lot of hopping around when reading/updating. > > Granted, if all the dimens you are adding are used all over then disregard this. Fixed this everywhere; there were a lot of places where I had defined a dimension to only use it in one place. Is definitely a lot easier to read now, and dimens.xml/colors.xml aren't so cluttered :)
	13 android:background="@drawable/website_settings_permission_spinner_item_backg round"

	14 android:ellipsize="marquee"

	15 android:gravity="center_vertical"

	16 android:singleLine="true"

	17 android:textColor="@color/website_settings_popup_permission_spinner_text"

	18 android:textSize="@dimen/website_settings_popup_permission_spinner_text" />

OLD	NEW