chrome/android/java/res/drawable/website_settings_permission_spinner_item_background.xml - Issue 620983002: Add Permissions to the PageInfo dialog on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable/website_settings_permission_spinner_item_background.xml

Issue 620983002: Add Permissions to the PageInfo dialog on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_info_dialog_shell_only_v2

Patch Set: Rebase and added arrow next to dropdowns on PageInfo screen Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable/website_settings_permission_spinner_item.xml ('k') | chrome/android/java/res/layout/website_settings.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2

	3 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

	4

	5 Use of this source code is governed by a BSD-style license that can be

	6 found in the LICENSE file.

	7 -->

	8 <layer-list xmlns:android="http://schemas.android.com/apk/res/android">

	9 <!-- To achieve a single border along the bottom, draw a rectangle offset by

	10 1dp in all dimensions but the bottom. -->

	11 <item android:top="-1dp" android:right="-1dp" android:left="-1dp">

	12 <shape android:shape="rectangle" >

	13 <stroke android:width="1dip" android:color="#e5e5e5"/>

	14 </shape>

	15 </item>

	16 <item><bitmap android:gravity="right" android:src="@drawable/page_info_arrow_d own" /></item>
	Ted C 2014/10/16 00:24:25 With this, I think the text can draw over the drop With this, I think the text can draw over the dropdown arrow. You might want to apply end padding to the spinner to make sure that isn't possible. sashab 2014/10/16 05:52:02 Yup, it's true, thanks for pointing this out :) Ad Show quoted text On 2014/10/16 00:24:25, Ted C wrote: > With this, I think the text can draw over the dropdown arrow. > > You might want to apply end padding to the spinner to make sure that isn't > possible. Yup, it's true, thanks for pointing this out :) Added padding, see test: http://imgur.com/LwzojsW
	17

	18 </layer-list>

OLD	NEW