Issue 620973003: Revert of specialize setConcat for scale+translate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 620973003: Revert of specialize setConcat for scale+translate (Closed)

Created:
6 years, 2 months ago by robertphillips

Modified:
6 years, 2 months ago

Reviewers:
jvanverth1, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of specialize setConcat for scale+translate (patchset #1 id:1 of https://codereview.chromium.org/620433002/) Reason for revert: Experimental to see if this revert "fixes" nanobench on the main console. Original issue's description: > specialize setConcat for scale+translate, helps drawText perf > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/e8db3ef2a2161084fa8eb1fd1d54c35bfff52d6c TBR=jvanverth@google.com,reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2a382f519999109b2e3445e73ddb4f0eae926b51

Created: 6 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -46 lines)			Patch
	M	include/core/SkMatrix.h	View		1 chunk	+0 lines, -23 lines	0 comments	Download
	M	src/core/SkMatrix.cpp	View		9 chunks	+43 lines, -23 lines	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of specialize setConcat for scale+translate

6 years, 2 months ago (2014-10-02 11:42:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620973003/1

6 years, 2 months ago (2014-10-02 11:42:45 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-02 11:43:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 2a382f519999109b2e3445e73ddb4f0eae926b51