On uninstall ask whether to delete profile.

On uninstall ask whether to delete profile.

BUG=8431

[kuchhal, 2009-04-07 08:50:46]

I still need to work on the UI (also need to get it blessed by the UI team) but
I wanted to get feedback on the approach. Can you please take a look?

[cpu_(ooo_6.6-7.5), 2009-04-09 01:06:07]

I don't have a problem with the approach. See my comments below about the nested
message loop.

http://codereview.chromium.org/62097/diff/1/4
File chrome/browser/browser_main_win.cc (right):

http://codereview.chromium.org/62097/diff/1/4#newcode47
Line 47:
MessageLoopForUI::current()->Run(g_browser_process->accelerator_handler());
running the main UI loop allows the browser to obey a bunch of messages that we
don't want to deal with. This was true with the original MessageBox() but is
probably worse here.

We need to add beng to get a more informed opinion.

http://codereview.chromium.org/62097/diff/1/8
File chrome/common/result_codes.h (right):

http://codereview.chromium.org/62097/diff/1/8#newcode39
Line 39: UNINSTALL_DELETE_PROFILE,   // Delete profile as well during uninstall.
The problem I see is that we might need to return more than one value, for
example |no_survey|

http://codereview.chromium.org/62097/diff/1/9
File chrome/installer/setup/uninstall.cc (right):

http://codereview.chromium.org/62097/diff/1/9#newcode322
Line 322: bool delete_profile = false;
delete_profile = (status == xxx );

[kuchhal, 2009-04-13 23:19:55]

Ben,
This change adds an option to delete profile data while uninstalling Chrome.
Carlos suggested I run this by you as this change creates a message loop which
he thought might not be the right way to do this.

Glen,
Can you please take a look at the new string text message and see if we want to
reword it?

[kuchhal, 2009-04-17 00:15:41]

Changed to use MessageBoxView. I am still not sure whats the best way to run
message loop so that we can exit after the user responds to the dialog box. Does
the current code look OK?

[kuchhal, 2009-04-17 00:51:56]

Yes that works. Can you please take a look now?

[Ben Goodger (Google), 2009-04-17 00:59:03]

UI stuff LGTM

http://codereview.chromium.org/62097/diff/6001/4017
File chrome/browser/browser_main_win.cc (right):

http://codereview.chromium.org/62097/diff/6001/4017#newcode69
Line 69: LOG(INFO) << "Failed to delete sentinel file.";
did you mean to leave these in?

[cpu_(ooo_6.6-7.5), 2009-04-17 01:36:57]

lgtm

[brian, 2009-04-17 16:11:57]

Awesome that you got this done, Rahul. Why did you take out the "Was it
something we said?" though?