Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 62097: On uninstall ask whether to delete profile. (Closed)

Created:
11 years, 8 months ago by kuchhal
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

On uninstall ask whether to delete profile. BUG=8431

Patch Set 1 #

Total comments: 3

Patch Set 2 : code review changes #

Patch Set 3 : Use MessageBoxView instead of writing a new view. #

Patch Set 4 : run message loop. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -28 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/browser_main_win.cc View 1 2 3 3 chunks +23 lines, -18 lines 1 comment Download
M chrome/browser/views/browser_views.vcproj View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/browser/views/uninstall_dialog.h View 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/browser/views/uninstall_dialog.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M chrome/common/result_codes.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 2 6 chunks +21 lines, -8 lines 0 comments Download
M chrome/installer/util/util_constants.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kuchhal
I still need to work on the UI (also need to get it blessed by ...
11 years, 8 months ago (2009-04-07 08:50:46 UTC) #1
cpu_(ooo_6.6-7.5)
I don't have a problem with the approach. See my comments below about the nested ...
11 years, 8 months ago (2009-04-09 01:06:07 UTC) #2
kuchhal
Ben, This change adds an option to delete profile data while uninstalling Chrome. Carlos suggested ...
11 years, 8 months ago (2009-04-13 23:19:55 UTC) #3
kuchhal
Changed to use MessageBoxView. I am still not sure whats the best way to run ...
11 years, 8 months ago (2009-04-17 00:15:41 UTC) #4
kuchhal
Yes that works. Can you please take a look now?
11 years, 8 months ago (2009-04-17 00:51:56 UTC) #5
Ben Goodger (Google)
UI stuff LGTM http://codereview.chromium.org/62097/diff/6001/4017 File chrome/browser/browser_main_win.cc (right): http://codereview.chromium.org/62097/diff/6001/4017#newcode69 Line 69: LOG(INFO) << "Failed to delete ...
11 years, 8 months ago (2009-04-17 00:59:03 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm
11 years, 8 months ago (2009-04-17 01:36:57 UTC) #7
brian
11 years, 8 months ago (2009-04-17 16:11:57 UTC) #8
Awesome that you got this done, Rahul. Why did you take out the "Was it
something we said?" though?

Powered by Google App Engine
This is Rietveld 408576698