Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 620943002: Add a bigint test with --no_intrinsify. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/corelib/big_integer_arith_vm_test.dart » ('j') | tests/corelib/corelib.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_ia32.cc
===================================================================
--- runtime/vm/intrinsifier_ia32.cc (revision 40918)
+++ runtime/vm/intrinsifier_ia32.cc (working copy)
@@ -912,8 +912,6 @@
}
-// TODO(regis): Once this intrinsic is implemented on all architectures, the
-// corresponding Dart method will be untested. Add a test with --no-intrinsify.
void Intrinsifier::Bigint_absAdd(Assembler* assembler) {
// static void _absAdd(Uint32List digits, int used,
// Uint32List a_digits, int a_used,
@@ -967,13 +965,11 @@
// Restore CTX and return.
__ popl(CTX);
- // TODO(regis): Confirm that returning Object::null() is not required.
+ // Returning Object::null() is not required, since this method is private.
__ ret();
}
-// TODO(regis): Once this intrinsic is implemented on all architectures, the
-// corresponding Dart method will be untested. Add a test with --no-intrinsify.
void Intrinsifier::Bigint_absSub(Assembler* assembler) {
// static void _absSub(Uint32List digits, int used,
// Uint32List a_digits, int a_used,
@@ -1023,13 +1019,11 @@
__ Bind(&done);
// Restore CTX and return.
__ popl(CTX);
- // TODO(regis): Confirm that returning Object::null() is not required.
+ // Returning Object::null() is not required, since this method is private.
__ ret();
}
-// TODO(regis): Once this intrinsic is implemented on all architectures, the
-// corresponding Dart method will be untested. Add a test with --no-intrinsify.
void Intrinsifier::Bigint_mulAdd(Assembler* assembler) {
// Pseudo code:
// static void _mulAdd(Uint32List x_digits, int xi,
@@ -1144,13 +1138,11 @@
__ popl(CTX);
__ Bind(&no_op);
- // TODO(regis): Confirm that returning Object::null() is not required.
+ // Returning Object::null() is not required, since this method is private.
__ ret();
}
-// TODO(regis): Once this intrinsic is implemented on all architectures, the
-// corresponding Dart method will be untested. Add a test with --no-intrinsify.
void Intrinsifier::Bigint_sqrAdd(Assembler* assembler) {
// Pseudo code:
// static void _sqrAdd(Uint32List x_digits, int i,
@@ -1283,13 +1275,11 @@
__ Drop(3);
__ popl(CTX);
__ Bind(&x_zero);
- // TODO(regis): Confirm that returning Object::null() is not required.
+ // Returning Object::null() is not required, since this method is private.
__ ret();
}
-// TODO(regis): Once this intrinsic is implemented on all architectures, the
-// corresponding Dart method will be untested. Add a test with --no-intrinsify.
void Intrinsifier::Bigint_estQuotientDigit(Assembler* assembler) {
// Pseudo code:
// static void _estQuotientDigit(Uint32List args, Uint32List digits, int i) {
@@ -1338,13 +1328,11 @@
// args[1] = qd
__ movl(FieldAddress(EDI, TypedData::data_offset() + kWordSize), EAX);
- // TODO(regis): Confirm that returning Object::null() is not required.
+ // Returning Object::null() is not required, since this method is private.
__ ret();
}
-// TODO(regis): Once this intrinsic is implemented on all architectures, the
-// corresponding Dart method will be untested. Add a test with --no-intrinsify.
void Intrinsifier::Montgomery_mulMod(Assembler* assembler) {
// Pseudo code:
// static void _mulMod(Uint32List args, Uint32List digits, int i) {
@@ -1371,7 +1359,7 @@
// args[1] = t mod DIGIT_BASE = low32(t)
__ movl(FieldAddress(EDI, TypedData::data_offset() + kWordSize), EAX);
- // TODO(regis): Confirm that returning Object::null() is not required.
+ // Returning Object::null() is not required, since this method is private.
__ ret();
}
« no previous file with comments | « no previous file | tests/corelib/big_integer_arith_vm_test.dart » ('j') | tests/corelib/corelib.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698