Add a bigint test with --no_intrinsify.

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 894 matching lines @@
 
 void Intrinsifier::Bigint_setDigits(Assembler* assembler) {
   __ movl(EAX, Address(ESP, + 1 * kWordSize));
   __ movl(ECX, Address(ESP, + 2 * kWordSize));
   __ StoreIntoObject(ECX,
                      FieldAddress(ECX, Bigint::digits_offset()), EAX, false);
   __ ret();
 }
 
 
-// TODO(regis): Once this intrinsic is implemented on all architectures, the
-// corresponding Dart method will be untested. Add a test with --no-intrinsify.
 void Intrinsifier::Bigint_absAdd(Assembler* assembler) {
   // static void _absAdd(Uint32List digits, int used,
   //                     Uint32List a_digits, int a_used,
   //                     Uint32List r_digits)
 
   // Preserve CTX to free ESI.
   __ pushl(CTX);
   ASSERT(CTX == ESI);
 
   __ movl(EDI, Address(ESP, 6 * kWordSize));  // digits
@@ skipping 33 matching lines @@
   __ decl(ECX);  // Does not affect CF.
   __ j(NOT_ZERO, &carry_loop, Assembler::kNearJump);
 
   __ Bind(&last_carry);
   __ movl(EAX, Immediate(0));
   __ adcl(EAX, Immediate(0));
   __ movl(FieldAddress(EBX, EDX, TIMES_4, TypedData::data_offset()), EAX);
 
   // Restore CTX and return.
   __ popl(CTX);
-  // TODO(regis): Confirm that returning Object::null() is not required.
+  // Returning Object::null() is not required, since this method is private.
   __ ret();
 }
 
 
-// TODO(regis): Once this intrinsic is implemented on all architectures, the
-// corresponding Dart method will be untested. Add a test with --no-intrinsify.
 void Intrinsifier::Bigint_absSub(Assembler* assembler) {
   // static void _absSub(Uint32List digits, int used,
   //                     Uint32List a_digits, int a_used,
   //                     Uint32List r_digits)
 
   // Preserve CTX to free ESI.
   __ pushl(CTX);
   ASSERT(CTX == ESI);
 
   __ movl(EDI, Address(ESP, 6 * kWordSize));  // digits
@@ skipping 29 matching lines @@
   __ movl(EAX, FieldAddress(EDI, EDX, TIMES_4, TypedData::data_offset()));
   __ sbbl(EAX, Immediate(0));
   __ movl(FieldAddress(EBX, EDX, TIMES_4, TypedData::data_offset()), EAX);
   __ incl(EDX);  // Does not affect CF.
   __ decl(ECX);  // Does not affect CF.
   __ j(NOT_ZERO, &carry_loop, Assembler::kNearJump);
 
   __ Bind(&done);
   // Restore CTX and return.
   __ popl(CTX);
-  // TODO(regis): Confirm that returning Object::null() is not required.
+  // Returning Object::null() is not required, since this method is private.
   __ ret();
 }
 
 
-// TODO(regis): Once this intrinsic is implemented on all architectures, the
-// corresponding Dart method will be untested. Add a test with --no-intrinsify.
 void Intrinsifier::Bigint_mulAdd(Assembler* assembler) {
   // Pseudo code:
   // static void _mulAdd(Uint32List x_digits, int xi,
   //                     Uint32List m_digits, int i,
   //                     Uint32List a_digits, int j, int n) {
   //   uint32_t x = x_digits[xi >> 1];  // xi is Smi.
   //   if (x == 0 || n == 0) {
   //     return;
   //   }
   //   uint32_t* mip = &m_digits[i >> 1];  // i is Smi.
@@ skipping 94 matching lines @@
   __ addl(ESI, Immediate(kWordSize));
   __ incl(Address(ESI, 0));  // c == 0 or 1
   __ j(CARRY, &propagate_carry_loop, Assembler::kNearJump);
 
   __ Bind(&done);
   __ Drop(1);  // n
   // Restore CTX and return.
   __ popl(CTX);
 
   __ Bind(&no_op);
-  // TODO(regis): Confirm that returning Object::null() is not required.
+  // Returning Object::null() is not required, since this method is private.
   __ ret();
 }
 
 
-// TODO(regis): Once this intrinsic is implemented on all architectures, the
-// corresponding Dart method will be untested. Add a test with --no-intrinsify.
 void Intrinsifier::Bigint_sqrAdd(Assembler* assembler) {
   // Pseudo code:
   // static void _sqrAdd(Uint32List x_digits, int i,
   //                     Uint32List a_digits, int used) {
   //   uint32_t* xip = &x_digits[i >> 1];  // i is Smi.
   //   uint32_t x = *xip++;
   //   if (x == 0) return;
   //   uint32_t* ajp = &a_digits[i];  // j == 2*i, i is Smi.
   //   uint32_t aj = *ajp;
   //   uint64_t t = x*x + aj;
@@ skipping 107 matching lines @@
 
   // *ajp++ = low32(t)
   // *ajp = high32(t)
   __ movl(Address(ESI, 0), EAX);
   __ movl(Address(ESI, kWordSize), EDX);
 
   // Restore CTX and return.
   __ Drop(3);
   __ popl(CTX);
   __ Bind(&x_zero);
-  // TODO(regis): Confirm that returning Object::null() is not required.
+  // Returning Object::null() is not required, since this method is private.
   __ ret();
 }
 
 
-// TODO(regis): Once this intrinsic is implemented on all architectures, the
-// corresponding Dart method will be untested. Add a test with --no-intrinsify.
 void Intrinsifier::Bigint_estQuotientDigit(Assembler* assembler) {
   // Pseudo code:
   // static void _estQuotientDigit(Uint32List args, Uint32List digits, int i) {
   //   uint32_t yt = args[_YT];  // _YT == 0.
   //   uint32_t* dp = &digits[i >> 1];  // i is Smi.
   //   uint32_t dh = dp[0];  // dh == digits[i >> 1].
   //   uint32_t qd;
   //   if (dh == yt) {
   //     qd = DIGIT_MASK;
   //   } else {
@@ skipping 28 matching lines @@
   // EAX = dl = dp[-1]
   __ movl(EAX, Address(EBX, -kWordSize));
 
   // EAX = qd = dh:dl / yt = EDX:EAX / ECX
   __ divl(ECX);
 
   __ Bind(&return_qd);
   // args[1] = qd
   __ movl(FieldAddress(EDI, TypedData::data_offset() + kWordSize), EAX);
 
-  // TODO(regis): Confirm that returning Object::null() is not required.
+  // Returning Object::null() is not required, since this method is private.
   __ ret();
 }
 
 
-// TODO(regis): Once this intrinsic is implemented on all architectures, the
-// corresponding Dart method will be untested. Add a test with --no-intrinsify.
 void Intrinsifier::Montgomery_mulMod(Assembler* assembler) {
   // Pseudo code:
   // static void _mulMod(Uint32List args, Uint32List digits, int i) {
   //   uint32_t rho = args[_RHO];  // _RHO == 0.
   //   uint32_t d = digits[i >> 1];  // i is Smi.
   //   uint64_t t = rho*d;
   //   args[_MU] = t mod DIGIT_BASE;  // _MU == 1.
   // }
 
   // EDI = args
   __ movl(EDI, Address(ESP, 3 * kWordSize));  // args
 
   // ECX = rho = args[0]
   __ movl(ECX, FieldAddress(EDI, TypedData::data_offset()));
 
   // EAX = digits[i >> 1]
   __ movl(EBX, Address(ESP, 2 * kWordSize));  // digits
   __ movl(EAX, Address(ESP, 1 * kWordSize));  // i is Smi
   __ movl(EAX, FieldAddress(EBX, EAX, TIMES_2, TypedData::data_offset()));
 
   // EDX:EAX = t = rho*d
   __ mull(ECX);
 
   // args[1] = t mod DIGIT_BASE = low32(t)
   __ movl(FieldAddress(EDI, TypedData::data_offset() + kWordSize), EAX);
 
-  // TODO(regis): Confirm that returning Object::null() is not required.
+  // Returning Object::null() is not required, since this method is private.
   __ ret();
 }
 
 
 // Check if the last argument is a double, jump to label 'is_smi' if smi
 // (easy to convert to double), otherwise jump to label 'not_double_smi',
 // Returns the last argument in EAX.
 static void TestLastArgumentIsDouble(Assembler* assembler,
                                      Label* is_smi,
                                      Label* not_double_smi) {
@@ skipping 719 matching lines @@
                         Isolate::current_tag_offset());
   // Set return value to Isolate::current_tag_.
   __ movl(EAX, current_tag_addr);
   __ ret();
 }
 
 #undef __
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32