Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 620933002: Move all files related to tracked preferences from c/b/prefs to c/b/prefs/tracked. (Closed)

Created:
6 years, 2 months ago by gab
Modified:
6 years, 2 months ago
CC:
chromium-reviews, erikwright (departed)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move all files related to tracked preferences from c/b/prefs to c/b/prefs/tracked. This is a long-standing task, I have been waiting to proceed with it to avoid complicated merges while things were hot on the settings protection front. Now is a good time to clean this up before doing further cleanup work. TBR=grt@chromium.org BUG=419505 Committed: https://crrev.com/7a1a0bc9cb0bb2c441f415fd4db6310258d0c018 Cr-Commit-Position: refs/heads/master@{#297811}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -3100 lines) Patch
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/prefs/interceptable_pref_filter.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/prefs/interceptable_pref_filter.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/browser/prefs/mock_validation_delegate.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/prefs/mock_validation_delegate.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/prefs/pref_hash_calculator.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/prefs/pref_hash_calculator.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M chrome/browser/prefs/pref_hash_calculator_unittest.cc View 1 chunk +0 lines, -206 lines 0 comments Download
D chrome/browser/prefs/pref_hash_filter.h View 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/browser/prefs/pref_hash_filter.cc View 1 chunk +0 lines, -227 lines 0 comments Download
M chrome/browser/prefs/pref_hash_filter_unittest.cc View 1 chunk +0 lines, -1059 lines 0 comments Download
D chrome/browser/prefs/pref_hash_store.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/prefs/pref_hash_store_impl.h View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/prefs/pref_hash_store_impl.cc View 1 chunk +0 lines, -311 lines 0 comments Download
M chrome/browser/prefs/pref_hash_store_impl_unittest.cc View 1 chunk +0 lines, -475 lines 0 comments Download
D chrome/browser/prefs/pref_hash_store_transaction.h View 1 chunk +0 lines, -95 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/prefs/tracked/interceptable_pref_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/prefs/tracked/interceptable_pref_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/prefs/tracked/mock_validation_delegate.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/prefs/tracked/mock_validation_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/prefs/tracked/pref_hash_calculator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/prefs/tracked/pref_hash_calculator.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/prefs/tracked/pref_hash_calculator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/prefs/tracked/pref_hash_filter.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/prefs/tracked/pref_hash_filter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/prefs/tracked/pref_hash_filter_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/prefs/tracked/pref_hash_store.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/prefs/tracked/pref_hash_store_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/prefs/tracked/pref_hash_store_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/prefs/tracked/pref_hash_store_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/prefs/tracked/pref_hash_store_transaction.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/tracked/tracked_atomic_preference.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/tracked/tracked_atomic_preference.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/tracked/tracked_preference_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/tracked/tracked_preferences_migration.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/tracked/tracked_preferences_migration.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/tracked/tracked_preferences_migration_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/prefs/tracked/tracked_split_preference.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/tracked/tracked_split_preference.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
gab
Finally getting around to doing this which you originally requested a while back. Now is ...
6 years, 2 months ago (2014-10-01 20:21:11 UTC) #4
gab
On 2014/10/01 20:21:11, gab wrote: > Finally getting around to doing this which you originally ...
6 years, 2 months ago (2014-10-01 20:48:42 UTC) #5
Bernhard Bauer
LGTM, thanks! I agree about PrefStoreManager; it's the entry point for the tracked prefs code, ...
6 years, 2 months ago (2014-10-02 06:36:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620933002/20001
6 years, 2 months ago (2014-10-02 06:36:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14909)
6 years, 2 months ago (2014-10-02 06:45:41 UTC) #10
gab
TBR grt for trivial side effects in incident_reporting/
6 years, 2 months ago (2014-10-02 11:56:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620933002/20001
6 years, 2 months ago (2014-10-02 11:57:12 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 1031f19ac2c805fcb9937f920a3ca38ecbb257cf
6 years, 2 months ago (2014-10-02 12:03:13 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 12:03:52 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a1a0bc9cb0bb2c441f415fd4db6310258d0c018
Cr-Commit-Position: refs/heads/master@{#297811}

Powered by Google App Engine
This is Rietveld 408576698