Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 620913003: Add messages on assertions. (Closed)

Created:
6 years, 2 months ago by Anand Mistry (off Chromium)
Modified:
6 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, rlp+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add messages on assertions. Without a message, you can't identify where the assertion was triggered, except via the javascript console. BUG=397019 Committed: https://crrev.com/479fb92ffb01afee1b56b8c7d96d9d775a1a1cbd Cr-Commit-Position: refs/heads/master@{#297775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M chrome/browser/resources/hotword/nacl_manager.js View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/hotword/state_manager.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Anand Mistry (off Chromium)
6 years, 2 months ago (2014-10-02 00:52:09 UTC) #2
Dan Beam
doesn't std{out,err} include the line number in the output?
6 years, 2 months ago (2014-10-02 01:18:19 UTC) #3
Anand Mistry (off Chromium)
On 2014/10/02 01:18:19, Dan Beam wrote: > doesn't std{out,err} include the line number in the ...
6 years, 2 months ago (2014-10-02 01:32:39 UTC) #4
Dan Beam
oh yeah, fair enough. lgtm
6 years, 2 months ago (2014-10-02 01:40:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620913003/1
6 years, 2 months ago (2014-10-02 01:50:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3c14c7769541d5289c4dac6ad0afd9e485c3741e
6 years, 2 months ago (2014-10-02 03:03:14 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 03:03:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/479fb92ffb01afee1b56b8c7d96d9d775a1a1cbd
Cr-Commit-Position: refs/heads/master@{#297775}

Powered by Google App Engine
This is Rietveld 408576698