Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp - Issue 62083004: Transfer date/time value to the chooser as a double

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp

Issue 62083004: Transfer date/time value to the chooser as a double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@datetime3

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h ('k') | Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp

diff --git a/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp b/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp

index 62e7522ffc1087a65750a194a421ab259feb6d3b..eb68bca7a8c1d8ca54f42a84856cbf37cd7e87ea 100644

--- a/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp

+++ b/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp

@@ -97,6 +97,15 @@ void BaseChooserOnlyDateAndTimeInputType::didChooseValue(const String& value)

element().setValue(value, DispatchInputAndChangeEvent);

}

+void BaseChooserOnlyDateAndTimeInputType::didChooseValue(double value)

+ ASSERT(std::isfinite(value) || std::isnan(value));

+ if (std::isnan(value))

+ element().setValue(emptyString(), DispatchInputAndChangeEvent);

+ else

+ element().setValueAsNumber(value, ASSERT_NO_EXCEPTION, DispatchInputAndChangeEvent);

void BaseChooserOnlyDateAndTimeInputType::didEndChooser()

{

m_dateTimeChooser.clear();