Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp - Issue 62083004: Transfer date/time value to the chooser as a double

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

Issue 62083004: Transfer date/time value to the chooser as a double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@datetime3

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp ('K') | « Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h ('k') | Source/core/html/shadow/PickerIndicatorElement.h » ('j') | Source/core/html/shadow/PickerIndicatorElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

diff --git a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

index ae9a7fe4dc5cde8e29150f0fa9b9aab6033496ea..5f164f52200796c1ad92ff962afcb8a392638c5e 100644

--- a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

+++ b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

@@ -262,6 +262,14 @@ void BaseMultipleFieldsDateAndTimeInputType::pickerIndicatorChooseValue(const St

edit->setOnlyYearMonthDay(date);

}

+void BaseMultipleFieldsDateAndTimeInputType::pickerIndicatorChooseValue(double value)

+ if (std::isnan(value))

+ element().setValue(String(), DispatchInputAndChangeEvent);

tkent 2013/11/07 19:42:07 Ditto.

keishi 2013/11/07 20:04:11 Done.

+ else

+ element().setValueAsNumber(value, ASSERT_NO_EXCEPTION, DispatchInputAndChangeEvent);

bool BaseMultipleFieldsDateAndTimeInputType::setupDateTimeChooserParameters(DateTimeChooserParameters& parameters)

{

return element().setupDateTimeChooserParameters(parameters);