Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: public/web/WebDateTimeChooserCompletion.h

Issue 62083004: Transfer date/time value to the chooser as a double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@datetime3
Patch Set: Fixed Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebDateTimeChooserCompletion.h
diff --git a/public/web/WebDateTimeChooserCompletion.h b/public/web/WebDateTimeChooserCompletion.h
index 91fe00b64f5652f5c9c473a7a744f32251afbf7b..c3132bd939b8b3dc8e8ed6126bb6bbd4c69c871e 100644
--- a/public/web/WebDateTimeChooserCompletion.h
+++ b/public/web/WebDateTimeChooserCompletion.h
@@ -36,8 +36,14 @@ public:
// Called with a date/time value in the HTML format. The callback instance
// is destroyed when this method is called.
+ // FIXME: Remove. Deprecated in favor of double version.
virtual void didChooseValue(const WebString&) = 0;
+ // Called with a date/time value in the HTML format. The callback instance
+ // is destroyed when this method is called. If the value is Nan it means an
tkent 2013/11/07 20:10:08 What about infinity values?
keishi 2013/11/19 03:28:04 It shouldn't be infinity. I added assertions to Ba
+ // empty value.
+ virtual void didChooseValue(double) = 0;
+
// Called when a user closed the chooser without choosing a value. The
// callback instance is destroyed when this method is called.
virtual void didCancelChooser() = 0;

Powered by Google App Engine
This is Rietveld 408576698