Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1594)

Unified Diff: Source/web/ExternalDateTimeChooser.cpp

Issue 62083004: Transfer date/time value to the chooser as a double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@datetime3
Patch Set: Fixed Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/ExternalDateTimeChooser.cpp
diff --git a/Source/web/ExternalDateTimeChooser.cpp b/Source/web/ExternalDateTimeChooser.cpp
index 44208db757fd12331504203675f74e7274b0d2ef..e3eb66c75071611d86bde053df51f88ba7463ccf 100644
--- a/Source/web/ExternalDateTimeChooser.cpp
+++ b/Source/web/ExternalDateTimeChooser.cpp
@@ -53,6 +53,12 @@ private:
delete this;
}
+ virtual void didChooseValue(double value) OVERRIDE
+ {
+ m_chooser->didChooseValue(value);
+ delete this;
+ }
+
virtual void didCancelChooser() OVERRIDE
{
m_chooser->didCancelChooser();
@@ -108,6 +114,7 @@ bool ExternalDateTimeChooser::openDateTimeChooser(ChromeClientImpl* chromeClient
webParams.type = toWebDateTimeInputType(parameters.type);
webParams.anchorRectInScreen = chromeClient->rootViewToScreen(parameters.anchorRectInRootView);
webParams.currentValue = parameters.currentValue;
+ webParams.doubleValue = parameters.doubleValue;
webParams.suggestionValues = parameters.suggestionValues;
webParams.localizedSuggestionValues = parameters.localizedSuggestionValues;
webParams.suggestionLabels = parameters.suggestionLabels;
@@ -139,6 +146,17 @@ void ExternalDateTimeChooser::didChooseValue(const WebString& value)
m_client->didEndChooser();
}
+void ExternalDateTimeChooser::didChooseValue(double value)
+{
+ if (m_client)
+ m_client->didChooseValue(value);
+ // didChooseValue might run JavaScript code, and endChooser() might be
+ // called. However DateTimeChooserCompletionImpl still has one reference to
+ // this object.
+ if (m_client)
+ m_client->didEndChooser();
+}
+
void ExternalDateTimeChooser::didCancelChooser()
{
if (m_client)

Powered by Google App Engine
This is Rietveld 408576698