Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: Source/core/svg/SVGImageElement.h

Issue 62083002: Remove support for the externalResourcesRequired attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebaseline test Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGGradientElement.idl ('k') | Source/core/svg/SVGImageElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGImageElement.h
diff --git a/Source/core/svg/SVGImageElement.h b/Source/core/svg/SVGImageElement.h
index 6a0798ca35156d3e25efbbfe21cd088699820366..880208914cc7ac15f73d9d1957fbaa5342dd0f35 100644
--- a/Source/core/svg/SVGImageElement.h
+++ b/Source/core/svg/SVGImageElement.h
@@ -25,7 +25,6 @@
#include "core/svg/SVGAnimatedBoolean.h"
#include "core/svg/SVGAnimatedLength.h"
#include "core/svg/SVGAnimatedPreserveAspectRatio.h"
-#include "core/svg/SVGExternalResourcesRequired.h"
#include "core/svg/SVGGraphicsElement.h"
#include "core/svg/SVGImageLoader.h"
#include "core/svg/SVGURIReference.h"
@@ -33,7 +32,6 @@
namespace WebCore {
class SVGImageElement FINAL : public SVGGraphicsElement,
- public SVGExternalResourcesRequired,
public SVGURIReference {
public:
static PassRefPtr<SVGImageElement> create(Document&);
@@ -44,6 +42,7 @@ private:
explicit SVGImageElement(Document&);
virtual bool isValid() const { return SVGTests::isValid(); }
+ virtual bool isStructurallyExternal() const { return !hrefCurrentValue().isNull(); }
virtual bool supportsFocus() const OVERRIDE { return hasFocusEventListeners(); }
bool isSupportedAttribute(const QualifiedName&);
@@ -71,7 +70,6 @@ private:
DECLARE_ANIMATED_LENGTH(Height, height)
DECLARE_ANIMATED_PRESERVEASPECTRATIO(PreserveAspectRatio, preserveAspectRatio)
DECLARE_ANIMATED_STRING(Href, href)
- DECLARE_ANIMATED_BOOLEAN(ExternalResourcesRequired, externalResourcesRequired)
END_DECLARE_ANIMATED_PROPERTIES
SVGImageLoader m_imageLoader;
« no previous file with comments | « Source/core/svg/SVGGradientElement.idl ('k') | Source/core/svg/SVGImageElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698