Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Side by Side Diff: Source/core/svg/SVGPolyElement.h

Issue 62083002: Remove support for the externalResourcesRequired attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 20
21 #ifndef SVGPolyElement_h 21 #ifndef SVGPolyElement_h
22 #define SVGPolyElement_h 22 #define SVGPolyElement_h
23 23
24 #include "SVGNames.h" 24 #include "SVGNames.h"
25 #include "core/svg/SVGAnimatedBoolean.h" 25 #include "core/svg/SVGAnimatedBoolean.h"
26 #include "core/svg/SVGExternalResourcesRequired.h"
27 #include "core/svg/SVGGraphicsElement.h" 26 #include "core/svg/SVGGraphicsElement.h"
28 #include "core/svg/SVGPointList.h" 27 #include "core/svg/SVGPointList.h"
29 28
30 namespace WebCore { 29 namespace WebCore {
31 30
32 class SVGPolyElement : public SVGGraphicsElement 31 class SVGPolyElement : public SVGGraphicsElement {
33 , public SVGExternalResourcesRequired {
34 public: 32 public:
35 SVGListPropertyTearOff<SVGPointList>* points(); 33 SVGListPropertyTearOff<SVGPointList>* points();
36 SVGListPropertyTearOff<SVGPointList>* animatedPoints(); 34 SVGListPropertyTearOff<SVGPointList>* animatedPoints();
37 35
38 SVGPointList& pointList() const { return m_points.value; } 36 SVGPointList& pointList() const { return m_points.value; }
39 37
40 static const SVGPropertyInfo* pointsPropertyInfo(); 38 static const SVGPropertyInfo* pointsPropertyInfo();
41 39
42 protected: 40 protected:
43 SVGPolyElement(const QualifiedName&, Document&); 41 SVGPolyElement(const QualifiedName&, Document&);
44 42
45 private: 43 private:
46 virtual bool isValid() const { return SVGTests::isValid(); } 44 virtual bool isValid() const { return SVGTests::isValid(); }
47 virtual bool supportsFocus() const OVERRIDE { return hasFocusEventListeners( ); } 45 virtual bool supportsFocus() const OVERRIDE { return hasFocusEventListeners( ); }
48 46
49 bool isSupportedAttribute(const QualifiedName&); 47 bool isSupportedAttribute(const QualifiedName&);
50 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE; 48 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;
51 virtual void svgAttributeChanged(const QualifiedName&); 49 virtual void svgAttributeChanged(const QualifiedName&);
52 50
53 virtual bool supportsMarkers() const { return true; } 51 virtual bool supportsMarkers() const { return true; }
54 52
55 // Custom 'points' property 53 // Custom 'points' property
56 static void synchronizePoints(SVGElement* contextElement); 54 static void synchronizePoints(SVGElement* contextElement);
57 static PassRefPtr<SVGAnimatedProperty> lookupOrCreatePointsWrapper(SVGElemen t* contextElement); 55 static PassRefPtr<SVGAnimatedProperty> lookupOrCreatePointsWrapper(SVGElemen t* contextElement);
58 56
59 BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGPolyElement) 57 BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGPolyElement)
Stephen Chennney 2013/11/06 16:45:43 I think all this can go - we have no properties to
Erik Dahlström (inactive) 2013/11/07 09:38:04 There are some BEGIN_REGISTER_ANIMATED_PROPERTIES
60 DECLARE_ANIMATED_BOOLEAN(ExternalResourcesRequired, externalResourcesReq uired)
61 END_DECLARE_ANIMATED_PROPERTIES 58 END_DECLARE_ANIMATED_PROPERTIES
62 59
63 protected: 60 protected:
64 mutable SVGSynchronizableAnimatedProperty<SVGPointList> m_points; 61 mutable SVGSynchronizableAnimatedProperty<SVGPointList> m_points;
65 }; 62 };
66 63
67 inline SVGPolyElement* toSVGPolyElement(SVGElement* element) 64 inline SVGPolyElement* toSVGPolyElement(SVGElement* element)
68 { 65 {
69 ASSERT_WITH_SECURITY_IMPLICATION(!element || element->hasTagName(SVGNames::p olygonTag) || element->hasTagName(SVGNames::polylineTag)); 66 ASSERT_WITH_SECURITY_IMPLICATION(!element || element->hasTagName(SVGNames::p olygonTag) || element->hasTagName(SVGNames::polylineTag));
70 return static_cast<SVGPolyElement*>(element); 67 return static_cast<SVGPolyElement*>(element);
71 } 68 }
72 69
73 } // namespace WebCore 70 } // namespace WebCore
74 71
75 #endif 72 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698