Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: Source/core/svg/SVGImageLoader.cpp

Issue 62083002: Remove support for the externalResourcesRequired attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2005 Alexander Kellett <lypanov@kde.org> 2 * Copyright (C) 2005, 2005 Alexander Kellett <lypanov@kde.org>
3 * Copyright (C) 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2008 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 21 matching lines...) Expand all
32 32
33 SVGImageLoader::SVGImageLoader(SVGImageElement* node) 33 SVGImageLoader::SVGImageLoader(SVGImageElement* node)
34 : ImageLoader(node) 34 : ImageLoader(node)
35 { 35 {
36 } 36 }
37 37
38 void SVGImageLoader::dispatchLoadEvent() 38 void SVGImageLoader::dispatchLoadEvent()
39 { 39 {
40 if (image()->errorOccurred()) 40 if (image()->errorOccurred())
41 element()->dispatchEvent(Event::create(EventTypeNames::error)); 41 element()->dispatchEvent(Event::create(EventTypeNames::error));
42 else {
43 SVGImageElement* imageElement = toSVGImageElement(element());
44 if (imageElement->externalResourcesRequiredBaseValue())
45 imageElement->sendSVGLoadEventIfPossible(true);
Stephen Chennney 2013/11/06 16:45:43 Don't we always need to dispatch a load event now,
Erik Dahlström (inactive) 2013/11/07 09:38:04 My preference would be to dispatch the image load
46 }
47 } 42 }
48 43
49 String SVGImageLoader::sourceURI(const AtomicString& attribute) const 44 String SVGImageLoader::sourceURI(const AtomicString& attribute) const
50 { 45 {
51 KURL base = element()->baseURI(); 46 KURL base = element()->baseURI();
52 if (base.isValid()) 47 if (base.isValid())
53 return KURL(base, stripLeadingAndTrailingHTMLSpaces(attribute)).string() ; 48 return KURL(base, stripLeadingAndTrailingHTMLSpaces(attribute)).string() ;
54 return element()->document().completeURL(stripLeadingAndTrailingHTMLSpaces(a ttribute)); 49 return element()->document().completeURL(stripLeadingAndTrailingHTMLSpaces(a ttribute));
55 } 50 }
56 51
57 } 52 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698