Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Side by Side Diff: Source/core/svg/SVGGradientElement.cpp

Issue 62083002: Remove support for the externalResourcesRequired attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 24 matching lines...) Expand all
35 #include "core/svg/SVGTransformList.h" 35 #include "core/svg/SVGTransformList.h"
36 #include "core/svg/SVGTransformable.h" 36 #include "core/svg/SVGTransformable.h"
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 // Animated property definitions 40 // Animated property definitions
41 DEFINE_ANIMATED_ENUMERATION(SVGGradientElement, SVGNames::spreadMethodAttr, Spre adMethod, spreadMethod, SVGSpreadMethodType) 41 DEFINE_ANIMATED_ENUMERATION(SVGGradientElement, SVGNames::spreadMethodAttr, Spre adMethod, spreadMethod, SVGSpreadMethodType)
42 DEFINE_ANIMATED_ENUMERATION(SVGGradientElement, SVGNames::gradientUnitsAttr, Gra dientUnits, gradientUnits, SVGUnitTypes::SVGUnitType) 42 DEFINE_ANIMATED_ENUMERATION(SVGGradientElement, SVGNames::gradientUnitsAttr, Gra dientUnits, gradientUnits, SVGUnitTypes::SVGUnitType)
43 DEFINE_ANIMATED_TRANSFORM_LIST(SVGGradientElement, SVGNames::gradientTransformAt tr, GradientTransform, gradientTransform) 43 DEFINE_ANIMATED_TRANSFORM_LIST(SVGGradientElement, SVGNames::gradientTransformAt tr, GradientTransform, gradientTransform)
44 DEFINE_ANIMATED_STRING(SVGGradientElement, XLinkNames::hrefAttr, Href, href) 44 DEFINE_ANIMATED_STRING(SVGGradientElement, XLinkNames::hrefAttr, Href, href)
45 DEFINE_ANIMATED_BOOLEAN(SVGGradientElement, SVGNames::externalResourcesRequiredA ttr, ExternalResourcesRequired, externalResourcesRequired)
46 45
47 BEGIN_REGISTER_ANIMATED_PROPERTIES(SVGGradientElement) 46 BEGIN_REGISTER_ANIMATED_PROPERTIES(SVGGradientElement)
48 REGISTER_LOCAL_ANIMATED_PROPERTY(spreadMethod) 47 REGISTER_LOCAL_ANIMATED_PROPERTY(spreadMethod)
49 REGISTER_LOCAL_ANIMATED_PROPERTY(gradientUnits) 48 REGISTER_LOCAL_ANIMATED_PROPERTY(gradientUnits)
50 REGISTER_LOCAL_ANIMATED_PROPERTY(gradientTransform) 49 REGISTER_LOCAL_ANIMATED_PROPERTY(gradientTransform)
51 REGISTER_LOCAL_ANIMATED_PROPERTY(href) 50 REGISTER_LOCAL_ANIMATED_PROPERTY(href)
52 REGISTER_LOCAL_ANIMATED_PROPERTY(externalResourcesRequired)
53 REGISTER_PARENT_ANIMATED_PROPERTIES(SVGElement) 51 REGISTER_PARENT_ANIMATED_PROPERTIES(SVGElement)
54 END_REGISTER_ANIMATED_PROPERTIES 52 END_REGISTER_ANIMATED_PROPERTIES
55 53
56 SVGGradientElement::SVGGradientElement(const QualifiedName& tagName, Document& d ocument) 54 SVGGradientElement::SVGGradientElement(const QualifiedName& tagName, Document& d ocument)
57 : SVGElement(tagName, document) 55 : SVGElement(tagName, document)
58 , m_spreadMethod(SVGSpreadMethodPad) 56 , m_spreadMethod(SVGSpreadMethodPad)
59 , m_gradientUnits(SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX) 57 , m_gradientUnits(SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX)
60 { 58 {
61 ScriptWrappable::init(this); 59 ScriptWrappable::init(this);
62 registerAnimatedPropertiesForSVGGradientElement(); 60 registerAnimatedPropertiesForSVGGradientElement();
63 } 61 }
64 62
65 bool SVGGradientElement::isSupportedAttribute(const QualifiedName& attrName) 63 bool SVGGradientElement::isSupportedAttribute(const QualifiedName& attrName)
66 { 64 {
67 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ()); 65 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
68 if (supportedAttributes.isEmpty()) { 66 if (supportedAttributes.isEmpty()) {
69 SVGURIReference::addSupportedAttributes(supportedAttributes); 67 SVGURIReference::addSupportedAttributes(supportedAttributes);
70 SVGExternalResourcesRequired::addSupportedAttributes(supportedAttributes );
71 supportedAttributes.add(SVGNames::gradientUnitsAttr); 68 supportedAttributes.add(SVGNames::gradientUnitsAttr);
72 supportedAttributes.add(SVGNames::gradientTransformAttr); 69 supportedAttributes.add(SVGNames::gradientTransformAttr);
73 supportedAttributes.add(SVGNames::spreadMethodAttr); 70 supportedAttributes.add(SVGNames::spreadMethodAttr);
74 } 71 }
75 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName); 72 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
76 } 73 }
77 74
78 void SVGGradientElement::parseAttribute(const QualifiedName& name, const AtomicS tring& value) 75 void SVGGradientElement::parseAttribute(const QualifiedName& name, const AtomicS tring& value)
79 { 76 {
80 if (!isSupportedAttribute(name)) { 77 if (!isSupportedAttribute(name)) {
(...skipping 18 matching lines...) Expand all
99 96
100 if (name == SVGNames::spreadMethodAttr) { 97 if (name == SVGNames::spreadMethodAttr) {
101 SVGSpreadMethodType propertyValue = SVGPropertyTraits<SVGSpreadMethodTyp e>::fromString(value); 98 SVGSpreadMethodType propertyValue = SVGPropertyTraits<SVGSpreadMethodTyp e>::fromString(value);
102 if (propertyValue > 0) 99 if (propertyValue > 0)
103 setSpreadMethodBaseValue(propertyValue); 100 setSpreadMethodBaseValue(propertyValue);
104 return; 101 return;
105 } 102 }
106 103
107 if (SVGURIReference::parseAttribute(name, value)) 104 if (SVGURIReference::parseAttribute(name, value))
108 return; 105 return;
109 if (SVGExternalResourcesRequired::parseAttribute(name, value))
110 return;
111 106
112 ASSERT_NOT_REACHED(); 107 ASSERT_NOT_REACHED();
113 } 108 }
114 109
115 void SVGGradientElement::svgAttributeChanged(const QualifiedName& attrName) 110 void SVGGradientElement::svgAttributeChanged(const QualifiedName& attrName)
116 { 111 {
117 if (!isSupportedAttribute(attrName)) { 112 if (!isSupportedAttribute(attrName)) {
118 SVGElement::svgAttributeChanged(attrName); 113 SVGElement::svgAttributeChanged(attrName);
119 return; 114 return;
120 } 115 }
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 float r, g, b, a; 154 float r, g, b, a;
160 color.getRGBA(r, g, b, a); 155 color.getRGBA(r, g, b, a);
161 156
162 stops.append(Gradient::ColorStop(offset, r, g, b, a)); 157 stops.append(Gradient::ColorStop(offset, r, g, b, a));
163 } 158 }
164 159
165 return stops; 160 return stops;
166 } 161 }
167 162
168 } 163 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698