Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 620803002: Video Player: Not hide the video control bar on error (Closed)

Created:
6 years, 2 months ago by yoshiki
Modified:
6 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: Not hide the video control bar on error The cast icon has moved to the video control bar, so we should keep it visible even on error. BUG=419651 TEST=manual Committed: https://crrev.com/c8043c9e8838f7ef9c86c90e791d78563d5557fb Cr-Commit-Position: refs/heads/master@{#297787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M ui/file_manager/video_player/css/video_player.css View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
yoshiki
@fukino-san, PTAL. Thanks.
6 years, 2 months ago (2014-10-02 06:56:21 UTC) #2
fukino
On 2014/10/02 06:56:21, yoshiki wrote: > @fukino-san, PTAL. Thanks. lgtm.
6 years, 2 months ago (2014-10-02 07:00:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620803002/1
6 years, 2 months ago (2014-10-02 07:03:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/21842)
6 years, 2 months ago (2014-10-02 07:14:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620803002/1
6 years, 2 months ago (2014-10-02 07:59:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9be931185d4747988b766ad8215d09dbf5bb93be
6 years, 2 months ago (2014-10-02 08:34:09 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 08:36:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8043c9e8838f7ef9c86c90e791d78563d5557fb
Cr-Commit-Position: refs/heads/master@{#297787}

Powered by Google App Engine
This is Rietveld 408576698