Issue 620793003: int128_test.cc: Add missing #include after d198c50abe9b

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 620793003: int128_test.cc: Add missing #include after d198c50abe9b (Closed)

Created:
6 years, 2 months ago by Mark Mentovai

Modified:
6 years, 2 months ago

Reviewers:
scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

int128_test.cc: Add missing #include after d198c50abe9b. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/ae7ad050908048a3878e5c8624312beac6899a99

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	util/numeric/int128_test.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

Looks like you missed one in the final round. No biggie.

6 years, 2 months ago (2014-10-01 19:39:54 UTC) #2

scottmg

On 2014/10/01 19:39:54, Mark Mentovai wrote: > Looks like you missed one in the final ...

6 years, 2 months ago (2014-10-01 20:36:36 UTC) #3

Mark Mentovai

Committed patchset #1 (id:1) manually as ae7ad050908048a3878e5c8624312beac6899a99 (presubmit successful).

6 years, 2 months ago (2014-10-01 20:57:00 UTC) #4

Mark Mentovai

6 years, 2 months ago (2014-10-01 20:58:01 UTC) #5

Message was sent while issue was closed.

It’s all right. Early-stage projects without formal continuous integration set
up have to expect some amount of this. I’m still glad to see someone else
contributing.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages