Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: Source/core/inspector/InspectorDOMAgent.h

Issue 620783002: Devtools Animations: Basic animation inspection & control in Styles pane (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review changes for AnimationSection Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorDOMAgent.h
diff --git a/Source/core/inspector/InspectorDOMAgent.h b/Source/core/inspector/InspectorDOMAgent.h
index 44a6be98fda4826ed16c486659cdb93acef8d930..146235292f2abeee2e9c6d3d1b11bbc7d42e96b3 100644
--- a/Source/core/inspector/InspectorDOMAgent.h
+++ b/Source/core/inspector/InspectorDOMAgent.h
@@ -85,6 +85,7 @@ struct EventListenerInfo {
class InspectorDOMAgent FINAL : public InspectorBaseAgent<InspectorDOMAgent>, public InspectorBackendDispatcher::DOMCommandHandler {
WTF_MAKE_NONCOPYABLE(InspectorDOMAgent);
+ friend class InspectorCSSAgent;
caseq 2014/10/02 09:48:01 Is this for access to the animation player map? Pl
samli 2014/10/03 06:05:04 Done.
public:
struct DOMListener : public WillBeGarbageCollectedMixin {
virtual ~DOMListener()
@@ -142,6 +143,11 @@ public:
virtual void highlightQuad(ErrorString*, const RefPtr<JSONArray>& quad, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) OVERRIDE;
virtual void highlightNode(ErrorString*, const RefPtr<JSONObject>& highlightConfig, const int* nodeId, const String* objectId) OVERRIDE;
virtual void highlightFrame(ErrorString*, const String& frameId, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) OVERRIDE;
+ virtual void getAnimationPlayersForNode(ErrorString*, int nodeId, RefPtr<TypeBuilder::Array<TypeBuilder::DOM::AnimationPlayer> >& animationPlayersArray) OVERRIDE;
+ virtual void pauseAnimationPlayer(ErrorString*, int sequenceNumber, RefPtr<TypeBuilder::DOM::AnimationPlayer>&) OVERRIDE;
caseq 2014/10/02 09:48:01 Here and below, int sequenceNumber -> const String
samli 2014/10/03 06:05:04 Acknowledged.
+ virtual void playAnimationPlayer(ErrorString*, int sequenceNumber, RefPtr<TypeBuilder::DOM::AnimationPlayer>&) OVERRIDE;
+ virtual void setCurrentTimeAnimationPlayer(ErrorString*, int sequenceNumber, double currentTime, RefPtr<TypeBuilder::DOM::AnimationPlayer>&) OVERRIDE;
+ virtual void getStateAnimationPlayer(ErrorString*, int sequenceNumber, double* currentTime, bool* isRunning) OVERRIDE;
caseq 2014/10/02 09:48:01 getAnimationPalyerState() / setAnimaitonPlayerCurr
samli 2014/10/03 06:05:04 Done.
virtual void copyTo(ErrorString*, int nodeId, int targetElementId, const int* anchorNodeId, int* newNodeId) OVERRIDE;
virtual void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* anchorNodeId, int* newNodeId) OVERRIDE;
@@ -246,6 +252,8 @@ private:
PassRefPtr<TypeBuilder::Array<TypeBuilder::DOM::Node> > buildArrayForContainerChildren(Node* container, int depth, NodeToIdMap* nodesMap);
PassRefPtr<TypeBuilder::DOM::EventListener> buildObjectForEventListener(const RegisteredEventListener&, const AtomicString& eventType, Node*, const String* objectGroupId);
PassRefPtr<TypeBuilder::Array<TypeBuilder::DOM::Node> > buildArrayForPseudoElements(Element*, NodeToIdMap* nodesMap);
+ PassRefPtr<TypeBuilder::DOM::AnimationPlayer> buildObjectForAnimationPlayer(AnimationPlayer&);
+ PassRefPtr<TypeBuilder::DOM::AnimationNode> buildObjectForAnimationNode(AnimationNode&);
Node* nodeForPath(const String& path);
@@ -278,6 +286,7 @@ private:
OwnPtrWillBeMember<DOMEditor> m_domEditor;
bool m_suppressAttributeModifiedEvent;
RawPtrWillBeMember<Listener> m_listener;
+ WillBeHeapHashMap<int, RefPtrWillBeMember<AnimationPlayer> > m_idToAnimationPlayer;
};

Powered by Google App Engine
This is Rietveld 408576698