Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 620753007: Fix bug in ALTERNATE_PROTOCOL_USAGE_MAPPING_MISSING histogram (Closed)

Created:
6 years, 2 months ago by Ryan Hamilton
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix bug in ALTERNATE_PROTOCOL_USAGE_MAPPING_MISSING histogram in which we would consider the mapping to be missing even if the probability was such that we would not honor the advertisement. BUG= Committed: https://crrev.com/413cdda9719e7e8b4e9410a9b9630e684e29fc0c Cr-Commit-Position: refs/heads/master@{#297773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M net/http/http_server_properties_impl.cc View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ryan Hamilton
6 years, 2 months ago (2014-10-01 23:10:30 UTC) #2
ramant (doing other things)
lgtm
6 years, 2 months ago (2014-10-01 23:27:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620753007/1
6 years, 2 months ago (2014-10-02 00:35:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ae9be40467056c41518bdcedec995e1d8b96abfb
6 years, 2 months ago (2014-10-02 02:58:33 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 02:59:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/413cdda9719e7e8b4e9410a9b9630e684e29fc0c
Cr-Commit-Position: refs/heads/master@{#297773}

Powered by Google App Engine
This is Rietveld 408576698