Source/core/rendering/RenderTextControl.cpp - Issue 620753006: Rendering API cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTextControl.cpp

Issue 620753006: Rendering API cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address jchaffraix remarks Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderTextControl.cpp

diff --git a/Source/core/rendering/RenderTextControl.cpp b/Source/core/rendering/RenderTextControl.cpp

index 523dd0c288b7035a104b19d6bc5a85d7bf36d0d4..8854c7381a9052df7f07f837df912652aef73581 100644

--- a/Source/core/rendering/RenderTextControl.cpp

+++ b/Source/core/rendering/RenderTextControl.cpp

@@ -100,18 +100,6 @@ int RenderTextControl::textBlockLogicalHeight() const

return logicalHeight() - borderAndPaddingLogicalHeight();

}

-int RenderTextControl::textBlockLogicalWidth() const

- Element* innerEditor = innerEditorElement();

- ASSERT(innerEditor);

- LayoutUnit unitWidth = logicalWidth() - borderAndPaddingLogicalWidth();

- if (innerEditor->renderer())

- unitWidth -= innerEditor->renderBox()->paddingStart() + innerEditor->renderBox()->paddingEnd();

- return unitWidth;

void RenderTextControl::updateFromElement()

{

Element* innerEditor = innerEditorElement();