Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 620753006: Rendering API cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderMultiColumnSet.h ('k') | Source/core/rendering/RenderProgress.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 } 259 }
260 260
261 void assertSubtreeClearedPaintInvalidationState() const 261 void assertSubtreeClearedPaintInvalidationState() const
262 { 262 {
263 for (const RenderObject* renderer = this; renderer; renderer = renderer- >nextInPreOrder()) 263 for (const RenderObject* renderer = this; renderer; renderer = renderer- >nextInPreOrder())
264 renderer->assertRendererClearedPaintInvalidationState(); 264 renderer->assertRendererClearedPaintInvalidationState();
265 } 265 }
266 266
267 #endif 267 #endif
268 268
269 bool skipInvalidationWhenLaidOutChildren() const;
270
271 // FIXME: This could be used when changing the size of a renderer without ch ildren to skip some invalidations. 269 // FIXME: This could be used when changing the size of a renderer without ch ildren to skip some invalidations.
272 bool rendererHasNoBoxEffect() const 270 bool rendererHasNoBoxEffect() const
273 { 271 {
274 return !style()->hasVisualOverflowingEffect() && !style()->hasBorder() & & !style()->hasBackground(); 272 return !style()->hasVisualOverflowingEffect() && !style()->hasBorder() & & !style()->hasBackground();
275 } 273 }
276 274
277 // Obtains the nearest enclosing block (including this block) that contribut es a first-line style to our inline 275 // Obtains the nearest enclosing block (including this block) that contribut es a first-line style to our inline
278 // children. 276 // children.
279 virtual RenderBlock* firstLineBlock() const; 277 virtual RenderBlock* firstLineBlock() const;
280 278
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 void setNeedsLayoutIsForbidden(bool flag) { m_setNeedsLayoutForbidden = flag ; } 316 void setNeedsLayoutIsForbidden(bool flag) { m_setNeedsLayoutForbidden = flag ; }
319 #endif 317 #endif
320 318
321 void addAbsoluteRectForLayer(LayoutRect& result); 319 void addAbsoluteRectForLayer(LayoutRect& result);
322 bool requiresAnonymousTableWrappers(const RenderObject*) const; 320 bool requiresAnonymousTableWrappers(const RenderObject*) const;
323 321
324 // Gets pseudoStyle from Shadow host(in case of input elements) 322 // Gets pseudoStyle from Shadow host(in case of input elements)
325 // or from Parent element. 323 // or from Parent element.
326 PassRefPtr<RenderStyle> getUncachedPseudoStyleFromParentOrShadowHost() const ; 324 PassRefPtr<RenderStyle> getUncachedPseudoStyleFromParentOrShadowHost() const ;
327 325
326 bool skipInvalidationWhenLaidOutChildren() const;
327
328 public: 328 public:
329 #ifndef NDEBUG 329 #ifndef NDEBUG
330 void showTreeForThis() const; 330 void showTreeForThis() const;
331 void showRenderTreeForThis() const; 331 void showRenderTreeForThis() const;
332 void showLineTreeForThis() const; 332 void showLineTreeForThis() const;
333 333
334 void showRenderObject() const; 334 void showRenderObject() const;
335 // We don't make printedCharacters an optional parameter so that 335 // We don't make printedCharacters an optional parameter so that
336 // showRenderObject can be called from gdb easily. 336 // showRenderObject can be called from gdb easily.
337 void showRenderObject(int printedCharacters) const; 337 void showRenderObject(int printedCharacters) const;
(...skipping 1219 matching lines...) Expand 10 before | Expand all | Expand 10 after
1557 void showTree(const blink::RenderObject*); 1557 void showTree(const blink::RenderObject*);
1558 void showLineTree(const blink::RenderObject*); 1558 void showLineTree(const blink::RenderObject*);
1559 void showRenderTree(const blink::RenderObject* object1); 1559 void showRenderTree(const blink::RenderObject* object1);
1560 // We don't make object2 an optional parameter so that showRenderTree 1560 // We don't make object2 an optional parameter so that showRenderTree
1561 // can be called from gdb easily. 1561 // can be called from gdb easily.
1562 void showRenderTree(const blink::RenderObject* object1, const blink::RenderObjec t* object2); 1562 void showRenderTree(const blink::RenderObject* object1, const blink::RenderObjec t* object2);
1563 1563
1564 #endif 1564 #endif
1565 1565
1566 #endif // RenderObject_h 1566 #endif // RenderObject_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderMultiColumnSet.h ('k') | Source/core/rendering/RenderProgress.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698