Source/core/rendering/RenderFrameSet.h - Issue 620753006: Rendering API cleanup

Side by Side Diff: Source/core/rendering/RenderFrameSet.h

Issue 620753006: Rendering API cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address jchaffraix remarks Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/rendering/RenderBoxModelObject.h ('K') | « Source/core/rendering/RenderFlowThread.cpp ('k') | Source/core/rendering/RenderImageResource.h » ('j') | Source/core/rendering/RenderMedia.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 2000 Simon Hausmann <hausmann@kde.org>	3 * (C) 2000 Simon Hausmann <hausmann@kde.org>

4 * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.	4 * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 Vector<bool> m_allowBorder;	53 Vector<bool> m_allowBorder;

54 };	54 };

55	55

56 class RenderFrameSet FINAL : public RenderBox {	56 class RenderFrameSet FINAL : public RenderBox {

57 public:	57 public:

58 RenderFrameSet(HTMLFrameSetElement*);	58 RenderFrameSet(HTMLFrameSetElement*);

59 virtual ~RenderFrameSet();	59 virtual ~RenderFrameSet();

60 virtual void trace(Visitor*) OVERRIDE;	60 virtual void trace(Visitor*) OVERRIDE;

61	61

62 RenderObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); }	62 RenderObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); }

63 RenderObject* lastChild() const { ASSERT(children() == virtualChildren()); r eturn children()->lastChild(); }
Julien - ping for review 2014/10/03 01:26:43 Ditto. Ditto. Julien - ping for review 2014/10/03 01:26:43 Ditto. Ditto.
64	63

65 // If you have a RenderFrameSet, use firstChild or lastChild instead.	64 // If you have a RenderFrameSet, use firstChild or lastChild instead.

66 void slowFirstChild() const WTF_DELETED_FUNCTION;	65 void slowFirstChild() const WTF_DELETED_FUNCTION;

67 void slowLastChild() const WTF_DELETED_FUNCTION;	66 void slowLastChild() const WTF_DELETED_FUNCTION;

68	67

69 const RenderObjectChildList* children() const { return &m_children; }	68 const RenderObjectChildList* children() const { return &m_children; }

70 RenderObjectChildList* children() { return &m_children; }	69 RenderObjectChildList* children() { return &m_children; }

71	70

72 FrameEdgeInfo edgeInfo() const;	71 FrameEdgeInfo edgeInfo() const;

73	72

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
132	131

133 bool m_isResizing;	132 bool m_isResizing;

134 bool m_isChildResizing;	133 bool m_isChildResizing;

135 };	134 };

136	135

137 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderFrameSet, isFrameSet());	136 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderFrameSet, isFrameSet());

138	137

139 } // namespace blink	138 } // namespace blink

140	139

141 #endif // RenderFrameSet_h	140 #endif // RenderFrameSet_h

OLD	NEW