Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: Source/core/rendering/RenderTableSection.h

Issue 620753006: Rendering API cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights reserv ed. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights reserv ed.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 // Helper class for paintObject. 43 // Helper class for paintObject.
44 class CellSpan { 44 class CellSpan {
45 public: 45 public:
46 CellSpan(unsigned start, unsigned end) 46 CellSpan(unsigned start, unsigned end)
47 : m_start(start) 47 : m_start(start)
48 , m_end(end) 48 , m_end(end)
49 { 49 {
50 } 50 }
51 51
52 unsigned start() const { return m_start; }
53 unsigned end() const { return m_end; }
54
55 unsigned& start() { return m_start; } 52 unsigned& start() { return m_start; }
56 unsigned& end() { return m_end; } 53 unsigned& end() { return m_end; }
Julien - ping for review 2014/10/02 16:47:49 This API seems deeply dangerous.
57 54
58 private: 55 private:
59 unsigned m_start; 56 unsigned m_start;
60 unsigned m_end; 57 unsigned m_end;
61 }; 58 };
62 59
63 class RenderTableCell; 60 class RenderTableCell;
64 class RenderTableRow; 61 class RenderTableRow;
65 62
66 class RenderTableSection FINAL : public RenderBox { 63 class RenderTableSection FINAL : public RenderBox {
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 static const bool needsDestruction = false; 328 static const bool needsDestruction = false;
332 }; 329 };
333 template<> struct VectorTraits<blink::RenderTableSection::RowStruct> : VectorTra itsBase<blink::RenderTableSection::RowStruct> { 330 template<> struct VectorTraits<blink::RenderTableSection::RowStruct> : VectorTra itsBase<blink::RenderTableSection::RowStruct> {
334 static const bool needsDestruction = false; 331 static const bool needsDestruction = false;
335 }; 332 };
336 #endif 333 #endif
337 334
338 } 335 }
339 336
340 #endif // RenderTableSection_h 337 #endif // RenderTableSection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698