Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: Source/core/rendering/RenderTable.h

Issue 620753006: Rendering API cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2010 Apple Inc. All rights reserv ed. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2010 Apple Inc. All rights reserv ed.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 return style()->isLeftToRightDirection() ? borderStart() : borderEnd(); 78 return style()->isLeftToRightDirection() ? borderStart() : borderEnd();
79 } 79 }
80 80
81 virtual int borderBottom() const OVERRIDE 81 virtual int borderBottom() const OVERRIDE
82 { 82 {
83 if (style()->isHorizontalWritingMode()) 83 if (style()->isHorizontalWritingMode())
84 return style()->isFlippedBlocksWritingMode() ? borderBefore() : bord erAfter(); 84 return style()->isFlippedBlocksWritingMode() ? borderBefore() : bord erAfter();
85 return style()->isLeftToRightDirection() ? borderEnd() : borderStart(); 85 return style()->isLeftToRightDirection() ? borderEnd() : borderStart();
86 } 86 }
87 87
88 Color bgColor() const { return resolveColor(CSSPropertyBackgroundColor); }
89
90 int outerBorderBefore() const; 88 int outerBorderBefore() const;
91 int outerBorderAfter() const; 89 int outerBorderAfter() const;
92 int outerBorderStart() const; 90 int outerBorderStart() const;
93 int outerBorderEnd() const; 91 int outerBorderEnd() const;
94 92
95 int outerBorderLeft() const 93 int outerBorderLeft() const
96 { 94 {
97 if (style()->isHorizontalWritingMode()) 95 if (style()->isHorizontalWritingMode())
98 return style()->isLeftToRightDirection() ? outerBorderStart() : oute rBorderEnd(); 96 return style()->isLeftToRightDirection() ? outerBorderStart() : oute rBorderEnd();
99 return style()->isFlippedBlocksWritingMode() ? outerBorderAfter() : oute rBorderBefore(); 97 return style()->isFlippedBlocksWritingMode() ? outerBorderAfter() : oute rBorderBefore();
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 const Vector<int>& columnPositions() const { return m_columnPos; } 143 const Vector<int>& columnPositions() const { return m_columnPos; }
146 void setColumnPosition(unsigned index, int position) 144 void setColumnPosition(unsigned index, int position)
147 { 145 {
148 // Note that if our horizontal border-spacing changed, our position will change but not 146 // Note that if our horizontal border-spacing changed, our position will change but not
149 // our column's width. In practice, horizontal border-spacing won't chan ge often. 147 // our column's width. In practice, horizontal border-spacing won't chan ge often.
150 m_columnLogicalWidthChanged |= m_columnPos[index] != position; 148 m_columnLogicalWidthChanged |= m_columnPos[index] != position;
151 m_columnPos[index] = position; 149 m_columnPos[index] = position;
152 } 150 }
153 151
154 RenderTableSection* header() const { return m_head; } 152 RenderTableSection* header() const { return m_head; }
155 RenderTableSection* footer() const { return m_foot; }
Julien - ping for review 2014/10/02 16:47:49 I would keep this one for consistency.
156 RenderTableSection* firstBody() const { return m_firstBody; } 153 RenderTableSection* firstBody() const { return m_firstBody; }
157 154
158 // This function returns 0 if the table has no section. 155 // This function returns 0 if the table has no section.
159 RenderTableSection* topSection() const; 156 RenderTableSection* topSection() const;
160 RenderTableSection* bottomSection() const; 157 RenderTableSection* bottomSection() const;
161 158
162 // This function returns 0 if the table has no non-empty sections. 159 // This function returns 0 if the table has no non-empty sections.
163 RenderTableSection* topNonEmptySection() const; 160 RenderTableSection* topNonEmptySection() const;
164 161
165 unsigned lastColumnIndex() const { return numEffCols() - 1; } 162 unsigned lastColumnIndex() const { return numEffCols() - 1; }
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 if (m_firstBody) 360 if (m_firstBody)
364 return m_firstBody; 361 return m_firstBody;
365 return m_foot; 362 return m_foot;
366 } 363 }
367 364
368 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderTable, isTable()); 365 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderTable, isTable());
369 366
370 } // namespace blink 367 } // namespace blink
371 368
372 #endif // RenderTable_h 369 #endif // RenderTable_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698