Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 620703002: Add isolate.clean_isolated_files and use in all related recipes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/gpu/api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_tests/api.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py
index c3be8a44492e29a4099322e029ea40db94edb4ec..687fb8dd4193b94cb07dcdd7204b87aaa9f94d99 100644
--- a/scripts/slave/recipe_modules/chromium_tests/api.py
+++ b/scripts/slave/recipe_modules/chromium_tests/api.py
@@ -232,6 +232,13 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
for test in builder_dict.get('tests', []):
tests_including_triggered.append(test)
+ isolated_targets = [
+ t.name for t in tests_including_triggered if t.uses_swarming
+ ]
+
+ if isolated_targets:
+ self.m.isolate.clean_isolated_files(self.m.chromium.output_dir)
+
for t in tests_including_triggered:
compile_targets.update(t.compile_targets(self.m))
@@ -242,9 +249,6 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
self.m.chromium_android.check_webview_licenses()
self.m.chromium_android.findbugs()
- isolated_targets = [
- t.name for t in tests_including_triggered if t.uses_swarming
- ]
if isolated_targets:
self.m.isolate.find_isolated_tests(
self.m.chromium.output_dir, targets=list(set(isolated_targets)))
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/gpu/api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698