Issue 620673006: Fix progress bar regression on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 620673006: Fix progress bar regression on Mac (Closed)

Created:
6 years, 2 months ago by ccameron

Modified:
6 years, 2 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, mkwst+moarreviews_chromium.org, jchaffraix+rendering, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix progress bar regression on Mac The clip rect in r183006 wasn't manually tested, and was wrong. Specify the un-translated clip rect, which empirically produces correct results in a variety of test scenarios (zoomed, retina, various page locations). Use a LocalCurrentGraphicsContext and delete ContextContainer, because it is largely redundant. BUG=419597 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183162

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -23 lines)			Patch
M	Source/core/rendering/RenderThemeChromiumMac.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/platform/mac/LocalCurrentGraphicsContext.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	Source/platform/mac/LocalCurrentGraphicsContext.mm	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620673006/1

6 years, 2 months ago (2014-10-02 20:36:26 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-02 21:43:16 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183162

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages