Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: chrome/browser/chromeos/login/lock/webui_screen_locker.cc

Issue 620663005: Lock screen for Chrome-Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one more nit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/lock/webui_screen_locker.cc
diff --git a/chrome/browser/chromeos/login/lock/webui_screen_locker.cc b/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
index d0876ee84382aece9ad290718da4cb8a716c409e..7d0f5cde14c969b02815940a687f6fdcd5617623 100644
--- a/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
+++ b/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
@@ -67,15 +67,16 @@ WebUIScreenLocker::WebUIScreenLocker(ScreenLocker* screen_locker)
is_observing_keyboard_(false),
weak_factory_(this) {
set_should_emit_login_prompt_visible(false);
+#if !defined(USE_ATHENA)
ash::Shell::GetInstance()->lock_state_controller()->AddObserver(this);
+ ash::Shell::GetInstance()->delegate()->AddVirtualKeyboardStateObserver(this);
+#endif
DBusThreadManager::Get()->GetPowerManagerClient()->AddObserver(this);
if (keyboard::KeyboardController::GetInstance()) {
keyboard::KeyboardController::GetInstance()->AddObserver(this);
is_observing_keyboard_ = true;
}
-
- ash::Shell::GetInstance()->delegate()->AddVirtualKeyboardStateObserver(this);
}
void WebUIScreenLocker::LockScreen() {
@@ -89,6 +90,7 @@ void WebUIScreenLocker::LockScreen() {
lock_window_->AddObserver(this);
WebUILoginView::Init();
lock_window_->SetContentsView(this);
+ lock_window_->SetBounds(bounds);
lock_window_->Show();
LoadURL(GURL(kLoginURL));
lock_window->Grab();
@@ -156,8 +158,13 @@ void WebUIScreenLocker::FocusUserPod() {
WebUIScreenLocker::~WebUIScreenLocker() {
DBusThreadManager::Get()->GetPowerManagerClient()->RemoveObserver(this);
+#if !defined(USE_ATHENA)
ash::Shell::GetInstance()->
lock_state_controller()->RemoveObserver(this);
+
+ ash::Shell::GetInstance()->delegate()->
+ RemoveVirtualKeyboardStateObserver(this);
+#endif
// In case of shutdown, lock_window_ may be deleted before WebUIScreenLocker.
if (lock_window_) {
lock_window_->RemoveObserver(this);
@@ -175,9 +182,6 @@ WebUIScreenLocker::~WebUIScreenLocker() {
is_observing_keyboard_ = false;
}
- ash::Shell::GetInstance()->delegate()->
- RemoveVirtualKeyboardStateObserver(this);
-
if (login::LoginScrollIntoViewEnabled())
ResetKeyboardOverscrollOverride();
}
« no previous file with comments | « chrome/browser/chromeos/login/lock/screen_locker.cc ('k') | chrome/browser/chromeos/login/ui/lock_window_aura.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698