athena/screen_lock/chrome/DEPS - Issue 620663005: Lock screen for Chrome-Athena

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: athena/screen_lock/chrome/DEPS

Issue 620663005: Lock screen for Chrome-Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set athena::FillLayoutManager for lock screen Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+athena/input/public",

	3 "+base",

	4 "+chrome/browser/chromeos/login/lock",
	Nikita (slow) 2014/10/10 10:53:06 I guess this is against current rules that athena I guess this is against current rules that athena is not allowed to depend on chrome directly. If this is a temporary dependency, at least add comment with a bug #. Dmitry Polukhin 2014/10/10 11:30:01 Done. Show quoted text On 2014/10/10 10:53:06, Nikita Kostylev wrote: > I guess this is against current rules that athena is not allowed to depend on > chrome directly. > > If this is a temporary dependency, at least add comment with a bug #. Done.
	5 ]

OLD	NEW