Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 620623002: Revert "Allow declarative webrequest and webrequest in extensions." (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Allow declarative webrequest and webrequest in extensions." Causing compile failures on Linux GN trybots. > - Update _api_features.json and _permissions.json to allow the following features in extensions: > - declarativeWebrequest, > - events > - webRequest > - webViewRequest > > - Move web_view_request_custom_bindings.js and web_view_request.json to extensions. > > - Remove ExtensionsAPIClient::GetRuleRegistry() since RuleRegisteryService has been moved to extension. > > - Clean up extensions/extensions.gyp. > > TBR=sky@chromium.org > BUG=352293 NOTREECHECKS=true NOTRY=true TBR=fsamuel@chromium.org,rockot@chromium.org,sky@chromium.org Committed: https://crrev.com/e650b32b0453a45e0bdcb248f93092f1bd1f817f Cr-Commit-Position: refs/heads/master@{#297471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -262 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 2 chunks +32 lines, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 4 chunks +34 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 2 chunks +14 lines, -0 lines 0 comments Download
A + chrome/common/extensions/api/web_view_request.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/chrome_web_view.js View 3 chunks +91 lines, -0 lines 0 comments Download
A + chrome/renderer/resources/extensions/web_view_request_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/declarative/declarative_api.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/browser/api/declarative/rules_registry_service.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M extensions/browser/api/extensions_api_client.h View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/api/extensions_api_client.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 3 chunks +2 lines, -23 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/common/api/_api_features.json View 4 chunks +0 lines, -34 lines 0 comments Download
M extensions/common/api/_permission_features.json View 2 chunks +0 lines, -18 lines 0 comments Download
D extensions/common/api/web_view_request.json View 1 chunk +0 lines, -10 lines 0 comments Download
M extensions/common/extension_api.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/common/permissions/extensions_api_permissions.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/extensions_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/extensions_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/renderer/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/resources/web_view.js View 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/renderer/resources/web_view_events.js View 5 chunks +1 line, -91 lines 0 comments Download
D extensions/renderer/resources/web_view_request_custom_bindings.js View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
This is a revert of https://codereview.chromium.org/596003002, which is probably causing the build failures on Linux ...
6 years, 2 months ago (2014-09-30 19:02:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620623002/1
6 years, 2 months ago (2014-09-30 19:02:58 UTC) #4
dcheng
+hanxi on the right patch this time (sorry for the spam >_<)
6 years, 2 months ago (2014-09-30 19:03:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as cb13917a6caf4fe553712b7c76e4999136cb4318
6 years, 2 months ago (2014-09-30 19:04:32 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 19:05:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e650b32b0453a45e0bdcb248f93092f1bd1f817f
Cr-Commit-Position: refs/heads/master@{#297471}

Powered by Google App Engine
This is Rietveld 408576698