Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 620603002: Revert of Fix swarming of browser_tests and sync_integration_tests on debug windows. (Closed)

Created:
6 years, 2 months ago by msw
Modified:
6 years, 2 months ago
Reviewers:
jam, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix swarming of browser_tests and sync_integration_tests on debug windows. (patchset #1 id:1 of https://codereview.chromium.org/617983002/) Reason for revert: failure: http://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/38020/steps/runhooks/logs/stdio Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit status 1 in /mnt/data/b/build/slave/Android_Builder/build Updating projects from gyp files... gyp: Key 'includes' repeated at level 1 with key path '' while reading /mnt/data/b/build/slave/Android_Builder/build/src/chrome/browser_tests.isolate while reading includes of /mnt/data/b/build/slave/Android_Builder/build/src/chrome/tab_capture_end2end_tests.isolate while reading includes of /mnt/data/b/build/slave/Android_Builder/build/src/chrome/chrome_tests.gypi while reading includes of /mnt/data/b/build/slave/Android_Builder/build/src/chrome/chrome.gyp Original issue's description: > Fix swarming of browser_tests and sync_integration_tests on debug windows. > > They need base.isolate to bring in the VS runtime DLLs. > > BUG=414808 > R=maruel@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/ae092e2a50702e43fc8165eaadd84c7f64977945 TBR=maruel@chromium.org,jam@chromium.org NOTREECHECKS=true NOTRY=true BUG=414808 Committed: https://crrev.com/ccbd723031f8f329837321b49599b834ac9e3f1b Cr-Commit-Position: refs/heads/master@{#297466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser_tests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Created Revert of Fix swarming of browser_tests and sync_integration_tests on debug windows.
6 years, 2 months ago (2014-09-30 18:40:18 UTC) #1
M-A Ruel
On 2014/09/30 18:40:18, msw wrote: > Created Revert of Fix swarming of browser_tests and sync_integration_tests ...
6 years, 2 months ago (2014-09-30 18:41:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620603002/1
6 years, 2 months ago (2014-09-30 18:43:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 19a408b45b857b0b59cf33d5e40da7373e023f56
6 years, 2 months ago (2014-09-30 18:44:18 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:44:54 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccbd723031f8f329837321b49599b834ac9e3f1b
Cr-Commit-Position: refs/heads/master@{#297466}

Powered by Google App Engine
This is Rietveld 408576698