chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h - Issue 620563002: ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h

Issue 620563002: ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/base/locale_util.h ('K') | « chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc ('k') | chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h

diff --git a/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h b/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h

index d2af076d8fc7ae9a10238b22761e02139390240a..0991af5875c3122220627adfbdd22caecceb721a 100644

--- a/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h

+++ b/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h

@@ -9,6 +9,7 @@

#include "base/basictypes.h"

#include "base/compiler_specific.h"

+#include "chrome/browser/chromeos/base/locale_util.h"

#include "chrome/browser/chromeos/login/screens/terms_of_service_screen_actor.h"

#include "chrome/browser/ui/webui/chromeos/login/base_screen_handler.h"

@@ -42,9 +43,8 @@ class TermsOfServiceScreenHandler : public BaseScreenHandler,

virtual void Initialize() OVERRIDE;

// Callback invoked after the UI locale has been changed.

- void OnLanguageChangedCallback(const std::string& requested_locale,

- const std::string& loaded_locale,

- const bool success);

+ void OnLanguageChangedCallback(

+ scoped_ptr<locale_util::LanguageSwitchResult> result);

// Switch to the user's preferred input method and show the screen. This

// method is called after it has been ensured that the current UI locale