chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc - Issue 620563002: ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc

Issue 620563002: ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update aftr review. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/chromeos/login/network_screen_handler.h ('K') | « chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc

index 9829474554e89dfe8f942cc86ae2e9f5082710a2..b98df05a23b2109a225a193fe9b38c917c53bb59 100644

--- a/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc

@@ -137,9 +137,7 @@ void TermsOfServiceScreenHandler::Initialize() {

}

void TermsOfServiceScreenHandler::OnLanguageChangedCallback(

- const std::string& requested_locale,

- const std::string& loaded_locale,

- const bool success) {

+ scoped_ptr<locale_util::LanguageSwitchResult> result) {

// Update the screen contents to the new locale.

base::DictionaryValue localized_strings;

static_cast<OobeUI*>(web_ui()->GetController())