Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 620553012: ServiceWorker: Update a page set for the test of ServiceWorker (Closed)

Created:
6 years, 2 months ago by shimazu
Modified:
6 years, 2 months ago
Reviewers:
ernstm
CC:
chromium-reviews, telemetry+watch_chromium.org, horo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Update a page set for the test of ServiceWorker Currently a wpr file is obsolete, and perf for SW cannot work correctly because of some spec changes. This is solved by this patch. BUG=372759 TEST=./tools/perf/run_benchmark --browser=android-chrome-shell service_worker.service_worker This must be executed after commenting out '@benchmark.Disabled' in tools/perf/benchmarks/service_worker.py. Committed: https://crrev.com/e4f0017af0abc216c66c7252dd53c39fe60693d2 Cr-Commit-Position: refs/heads/master@{#298354}

Patch Set 1 #

Patch Set 2 : Recreate wpr file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M tools/perf/page_sets/data/service_worker.json View 1 1 chunk +1 line, -4 lines 0 comments Download
A tools/perf/page_sets/data/service_worker_001.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
D tools/perf/page_sets/data/service_worker_025.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/service_worker.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
shimazu
Could you review in this patch? :)
6 years, 2 months ago (2014-10-02 05:43:07 UTC) #2
ernstm
On 2014/10/02 05:43:07, makoto wrote: > Could you review in this patch? :) service_worker.json still ...
6 years, 2 months ago (2014-10-03 18:16:41 UTC) #3
shimazu
On 2014/10/03 18:16:41, ernstm wrote: > On 2014/10/02 05:43:07, makoto wrote: > > Could you ...
6 years, 2 months ago (2014-10-06 06:43:12 UTC) #4
ernstm
On 2014/10/06 06:43:12, makoto wrote: > On 2014/10/03 18:16:41, ernstm wrote: > > On 2014/10/02 ...
6 years, 2 months ago (2014-10-06 16:55:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620553012/20001
6 years, 2 months ago (2014-10-06 23:20:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/15848)
6 years, 2 months ago (2014-10-06 23:58:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620553012/20001
6 years, 2 months ago (2014-10-07 00:57:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2fff5b9f296a9a01779aa7ff49948baec110d251
6 years, 2 months ago (2014-10-07 03:44:38 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 03:46:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e4f0017af0abc216c66c7252dd53c39fe60693d2
Cr-Commit-Position: refs/heads/master@{#298354}

Powered by Google App Engine
This is Rietveld 408576698