Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: Source/core/rendering/RenderSelectionInfo.h

Issue 620553009: Move selection invalidations to the invalidation phase (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated change after review comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 28 matching lines...) Expand all
39 , m_state(o->selectionState()) 39 , m_state(o->selectionState())
40 { 40 {
41 } 41 }
42 42
43 void trace(Visitor* visitor) 43 void trace(Visitor* visitor)
44 { 44 {
45 visitor->trace(m_object); 45 visitor->trace(m_object);
46 visitor->trace(m_paintInvalidationContainer); 46 visitor->trace(m_paintInvalidationContainer);
47 } 47 }
48 48
49 RenderObject* object() const { return m_object.get(); }
yosin_UTC9 2014/10/02 02:18:27 nit: I prefer introducing |SelectionInfo::setShoul
50
49 protected: 51 protected:
50 RawPtrWillBeMember<RenderObject> m_object; 52 RawPtrWillBeMember<RenderObject> m_object;
51 RawPtrWillBeMember<const RenderLayerModelObject> m_paintInvalidationContaine r; 53 RawPtrWillBeMember<const RenderLayerModelObject> m_paintInvalidationContaine r;
52 RenderObject::SelectionState m_state; 54 RenderObject::SelectionState m_state;
53 }; 55 };
54 56
55 // This struct is used when the selection changes to cache the old and new state of the selection for each RenderObject. 57 // This struct is used when the selection changes to cache the old and new state of the selection for each RenderObject.
56 class RenderSelectionInfo FINAL : public RenderSelectionInfoBase { 58 class RenderSelectionInfo FINAL : public RenderSelectionInfoBase {
57 public: 59 public:
58 RenderSelectionInfo(RenderObject* o) 60 RenderSelectionInfo(RenderObject* o)
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 private: 132 private:
131 RenderBlock* block() const { return toRenderBlock(m_object); } 133 RenderBlock* block() const { return toRenderBlock(m_object); }
132 134
133 GapRects m_rects; // relative to paint invalidation container 135 GapRects m_rects; // relative to paint invalidation container
134 }; 136 };
135 137
136 } // namespace blink 138 } // namespace blink
137 139
138 140
139 #endif // RenderSelectionInfo_h 141 #endif // RenderSelectionInfo_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698