Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 620553004: Superficial gyp changes to not immediately error out on Windows (Closed)

Created:
6 years, 2 months ago by scottmg
Modified:
6 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/7dda7b3228817cfad06e6ee523271c24ddabe416

Patch Set 1 #

Total comments: 2

Patch Set 2 : guard all tools in if mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -114 lines) Patch
M tools/tools.gyp View 1 1 chunk +74 lines, -68 lines 0 comments Download
M util/util.gyp View 4 chunks +54 lines, -46 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
scottmg
(let me know if you'd rather not deal with these yet, was just planning on ...
6 years, 2 months ago (2014-09-30 19:53:04 UTC) #2
Mark Mentovai
Thanks, Scott, I’m happy to deal with this now. https://codereview.chromium.org/620553004/diff/1/tools/tools.gyp File tools/tools.gyp (right): https://codereview.chromium.org/620553004/diff/1/tools/tools.gyp#newcode75 tools/tools.gyp:75: ...
6 years, 2 months ago (2014-09-30 19:55:01 UTC) #3
scottmg
Thanks https://codereview.chromium.org/620553004/diff/1/tools/tools.gyp File tools/tools.gyp (right): https://codereview.chromium.org/620553004/diff/1/tools/tools.gyp#newcode75 tools/tools.gyp:75: 'conditions': [ On 2014/09/30 19:55:01, Mark Mentovai wrote: ...
6 years, 2 months ago (2014-09-30 19:59:50 UTC) #4
Mark Mentovai
LGTM. I’ve added you to crashpad-committers. Thank you!
6 years, 2 months ago (2014-09-30 20:09:43 UTC) #5
scottmg
Committed patchset #2 (id:20001) manually as 7dda7b3228817cfad06e6ee523271c24ddabe416 (presubmit successful).
6 years, 2 months ago (2014-09-30 20:11:07 UTC) #6
scottmg
6 years, 2 months ago (2014-09-30 20:11:15 UTC) #7
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698