Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 620533002: Remove support for SkPicture::clone(). (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
CC:
reviews_skia.org, robertphillips
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove support for SkPicture::clone(). This folds SK_SUPPORT_LEGACY_PICTURE_CLONE through as undefined. Chrome's not used clone() for a month or two, and we don't use it ourselves. Don't think Android ever did. CQ_EXTRA_TRYBOTS=tryserver.skia:Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT-Trybot BUG=skia: Committed: https://skia.googlesource.com/skia/+/5bc760a6a6a61ff462a204e0c051ad6147760223

Patch Set 1 #

Patch Set 2 : todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -88 lines) Patch
M include/core/SkPicture.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/core/SkPictureData.h View 1 2 chunks +0 lines, -18 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620533002/1
6 years, 2 months ago (2014-09-30 17:02:06 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-09-30 17:02:07 UTC) #3
commit-bot: I haz the power
Presubmit check for 620533002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 2 months ago (2014-09-30 17:02:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620533002/20001
6 years, 2 months ago (2014-09-30 17:03:06 UTC) #6
mtklein
This one needs an include/ stamp. All deletions!
6 years, 2 months ago (2014-09-30 17:07:38 UTC) #9
robertphillips
lgtm
6 years, 2 months ago (2014-09-30 17:11:19 UTC) #11
reed1
api lgtm
6 years, 2 months ago (2014-09-30 17:12:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620533002/20001
6 years, 2 months ago (2014-09-30 17:14:16 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:14:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 5bc760a6a6a61ff462a204e0c051ad6147760223

Powered by Google App Engine
This is Rietveld 408576698