Issue 62048: Fix a crash when canceling a save page operation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62048: Fix a crash when canceling a save page operation. (Closed)

Created:
11 years, 8 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash when canceling a save page operation. This crash occurs under the following conditions: 1. Launch Chrome and navigate to any web page 2. Save that page (via ctrl+s or menu option) 3. Click cancel in the Save As dialog box that appears 4. Save the page again This fix checks to see if the SavePackage was initialized when handling a stop operation, and skips it if nothing has started. BUG=9738 (http://crbug.com/9738) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13148

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	chrome/browser/download/save_package.cc	View		4 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ok

Expand Messages | Collapse Messages

Issue 62048: Fix a crash when canceling a save page operation. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages